Page MenuHomeFreeBSD
Differential D31051

bhyve: use a fixed 32 bit BAR base address
ClosedPublic
Actions

Authored by corvink on Jul 5 2021, 1:27 PM.
Tags
Referenced Files
F131021839: D31051.id98833.diff
Sat, Oct 4, 8:18 AM
Unknown Object (File)
Wed, Oct 1, 11:50 PM
Unknown Object (File)
Fri, Sep 26, 6:17 PM
Unknown Object (File)
Sat, Sep 20, 6:30 AM
Unknown Object (File)
Aug 31 2025, 3:55 PM
Unknown Object (File)
Aug 5 2025, 1:08 AM
Unknown Object (File)
Aug 1 2025, 11:10 AM
Unknown Object (File)
Jul 25 2025, 10:37 PM
View All Files
Subscribers
bcran
imp
markj
rgrimes
bhyve

Details

Reviewers
grehan
manu
markj
Group Reviewers
bhyve
Commits
rGf281bda11a1a: bhyve: use a fixed 32 bit BAR base address
rG5cf21e48ccf1: bhyve: use a fixed 32 bit BAR base address
Summary

OVMF always uses 0xC0000000 as base address for 32 bit PCI MMIO space.
For that reason, we should use that address too.

Note: You can have a look at https://github.com/Beckhoff/freebsd-src/commits/phab/corvink/fixed-bar-32

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

corvink created this revision.Jul 5 2021, 1:27 PM
Herald added subscribers: bcran, rgrimes. · View Herald TranscriptJul 5 2021, 1:27 PM
corvink requested review of this revision.Jul 5 2021, 1:27 PM
corvink updated this revision to Diff 91796.
corvink updated this revision to Diff 91798.Jul 5 2021, 1:33 PM
corvink edited the summary of this revision. (Show Details)Jul 5 2021, 1:38 PM
corvink updated this revision to Diff 96790.Oct 13 2021, 8:53 AM
corvink retitled this revision from bhyve: use fixed 32 bit BAR base address to bhyve: use a fixed 32 bit BAR base address.
corvink edited the summary of this revision. (Show Details)
  • rebase
corvink added reviewers: grehan, manu.Nov 17 2021, 11:27 AM
corvink set the repository for this revision to rG FreeBSD src repository.
corvink added a subscriber: bhyve.
Herald added a subscriber: imp. · View Herald TranscriptNov 17 2021, 11:27 AM
manu accepted this revision.Nov 18 2021, 3:30 PM

LGMT.
Will commit next monday unless someone have more comments until then.

This revision is now accepted and ready to land.Nov 18 2021, 3:30 PM
markj added a subscriber: markj.Nov 20 2021, 3:21 PM
markj added inline comments.
usr.sbin/bhyve/pci_emul.c
1154

This limit is fixed in libvmmapi. Wouldn't it be cleaner to assert that it is using the value we want, rather than just assuming?

corvink updated this revision to Diff 98828.Nov 22 2021, 10:13 AM

Add a check for lowmem_limit

This revision now requires review to proceed.Nov 22 2021, 10:13 AM
corvink marked an inline comment as done.Nov 22 2021, 10:15 AM
corvink added inline comments.
usr.sbin/bhyve/pci_emul.c
1154

Decreasing the lowmem_limit shouldn't hurt. However, bhyve should always use 0xC0000000 as membase32 because OVMF uses it too.

corvink edited the summary of this revision. (Show Details)Nov 22 2021, 10:17 AM
markj accepted this revision as: markj.Nov 22 2021, 2:16 PM
This revision is now accepted and ready to land.Nov 22 2021, 2:16 PM
Closed by commit rG5cf21e48ccf1: bhyve: use a fixed 32 bit BAR base address (authored by corvink, committed by manu). · Explain WhyNov 22 2021, 3:30 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG5cf21e48ccf1: bhyve: use a fixed 32 bit BAR base address.
manu added a commit: rGf281bda11a1a: bhyve: use a fixed 32 bit BAR base address.Jan 14 2022, 2:21 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
10 lines

Diff 96790

View Options

usr.sbin/bhyve/pci_emul.c

Loading...