Page MenuHomeFreeBSD

bhyve: use a fixed 32 bit BAR base address
ClosedPublic

Authored by corvink on Jul 5 2021, 1:27 PM.
Tags
Referenced Files
Unknown Object (File)
Feb 10 2024, 4:59 AM
Unknown Object (File)
Jan 12 2024, 7:56 AM
Unknown Object (File)
Dec 23 2023, 4:33 AM
Unknown Object (File)
Dec 16 2023, 4:17 AM
Unknown Object (File)
Dec 1 2023, 3:11 AM
Unknown Object (File)
Nov 7 2023, 9:10 PM
Unknown Object (File)
Nov 7 2023, 4:36 AM
Unknown Object (File)
Nov 7 2023, 4:13 AM

Details

Summary

OVMF always uses 0xC0000000 as base address for 32 bit PCI MMIO space.
For that reason, we should use that address too.

Note: You can have a look at https://github.com/Beckhoff/freebsd-src/commits/phab/corvink/fixed-bar-32

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

corvink updated this revision to Diff 91796.
corvink retitled this revision from bhyve: use fixed 32 bit BAR base address to bhyve: use a fixed 32 bit BAR base address.
corvink edited the summary of this revision. (Show Details)
  • rebase
corvink set the repository for this revision to rG FreeBSD src repository.
corvink added a subscriber: bhyve.

LGMT.
Will commit next monday unless someone have more comments until then.

This revision is now accepted and ready to land.Nov 18 2021, 3:30 PM
markj added inline comments.
usr.sbin/bhyve/pci_emul.c
1154

This limit is fixed in libvmmapi. Wouldn't it be cleaner to assert that it is using the value we want, rather than just assuming?

Add a check for lowmem_limit

This revision now requires review to proceed.Nov 22 2021, 10:13 AM
corvink added inline comments.
usr.sbin/bhyve/pci_emul.c
1154

Decreasing the lowmem_limit shouldn't hurt. However, bhyve should always use 0xC0000000 as membase32 because OVMF uses it too.

This revision is now accepted and ready to land.Nov 22 2021, 2:16 PM
This revision was automatically updated to reflect the committed changes.