Page MenuHomeFreeBSD

bhyve: use a fixed 32 bit BAR base address
ClosedPublic

Authored by c.koehne_beckhoff.com on Jul 5 2021, 1:27 PM.

Details

Summary

OVMF always uses 0xC0000000 as base address for 32 bit PCI MMIO space.
For that reason, we should use that address too.

Note: You can have a look at https://github.com/Beckhoff/freebsd-src/commits/phab/corvink/fixed-bar-32

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

c.koehne_beckhoff.com retitled this revision from bhyve: use fixed 32 bit BAR base address to bhyve: use a fixed 32 bit BAR base address.
c.koehne_beckhoff.com edited the summary of this revision. (Show Details)
  • rebase

LGMT.
Will commit next monday unless someone have more comments until then.

This revision is now accepted and ready to land.Thu, Nov 18, 3:30 PM
markj added inline comments.
usr.sbin/bhyve/pci_emul.c
1154

This limit is fixed in libvmmapi. Wouldn't it be cleaner to assert that it is using the value we want, rather than just assuming?

This revision now requires review to proceed.Mon, Nov 22, 10:13 AM
c.koehne_beckhoff.com added inline comments.
usr.sbin/bhyve/pci_emul.c
1154

Decreasing the lowmem_limit shouldn't hurt. However, bhyve should always use 0xC0000000 as membase32 because OVMF uses it too.

This revision is now accepted and ready to land.Mon, Nov 22, 2:16 PM
This revision was automatically updated to reflect the committed changes.