Page MenuHomeFreeBSD
Differential D31931

x86: duplicate acpi_wakeup.c per i386 and amd64
ClosedPublic
Actions

Authored by kib on Sep 13 2021, 5:02 PM.
Tags
None
Referenced Files
F161516327: D31931.id95061.diff
Sat, Jul 4, 11:34 AM
F161469113: D31931.id95051.diff
Sat, Jul 4, 2:50 AM
F161462424: D31931.id.diff
Sat, Jul 4, 1:11 AM
F161460297: D31931.id95083.diff
Sat, Jul 4, 12:38 AM
Unknown Object (File)
Wed, Jul 1, 12:48 AM
Unknown Object (File)
Tue, Jun 23, 12:47 AM
Unknown Object (File)
Sun, Jun 14, 5:21 PM
Unknown Object (File)
Sun, Jun 14, 6:30 AM
View All Files
Subscribers
None

Details

Reviewers
markj
Commits
rG1c56781cc915: amd64 wakeup: rework trampoline page allocation
rG2b6eec531a1b: x86: duplicate acpi_wakeup.c per i386 and amd64
Summary

The file as is is the maze of #ifdef passages, all slightly different. Divorcing i386 and amd64 version actually makes changing the code easier, also no changes for i386 are planned.

amd64 wakeup: rework trampoline page allocation

There is no need to restrict trampoline page table to low 1M, it should work with any pages below 4G. Only wakeup code itself should be below 1M.

Do not waste level 5 page when LA48 mode is used.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Sep 13 2021, 5:02 PM
kib created this revision.
markj added inline comments.Sep 13 2021, 6:07 PM
sys/amd64/acpica/acpi_wakeup.c
334

Shouldn't it be i = 0?

kib updated this revision to Diff 95061.Sep 13 2021, 6:14 PM
kib marked an inline comment as done.

Fix silly off by one

markj accepted this revision.Sep 13 2021, 6:19 PM
This revision is now accepted and ready to land.Sep 13 2021, 6:19 PM
Closed by commit rG2b6eec531a1b: x86: duplicate acpi_wakeup.c per i386 and amd64 (authored by kib). · Explain WhySep 13 2021, 9:24 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG2b6eec531a1b: x86: duplicate acpi_wakeup.c per i386 and amd64.
kib added a commit: rG1c56781cc915: amd64 wakeup: rework trampoline page allocation.

Revision Contents
Changeset List

PathSize
sys/
amd64/
acpica/
x86/
acpica/
87 lines
conf/
1 line
1 line
1 line
i386/
acpica/
x86/
acpica/
164 lines
x86/
acpica/

Diff 95083

View Options

sys/amd64/acpica/acpi_wakeup.c

Loading...
View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.i386

Loading...
View Options

sys/conf/files.x86

Loading...
View Options

sys/i386/acpica/acpi_wakeup.c

Loading...
View Options

sys/x86/acpica/acpi_wakeup.c

Loading...