hyperv: scanning locking is using the bus mtx
ClosedPublic
Actions

Authored by imp on Sep 5 2021, 3:35 AM.

Details

Reviewers

mav
jhb
• hselasky
markj
kib
bhughes
whu

Commits

rGf581847a7277: hyperv: scanning locking is using the bus mtx

Summary

The scanning code uses Giant to coordinate its accesses to newbus as
well as to synchronize a little state within hyperv's vmbus. Switch to
the new bus_topo_* functions instead of referring to Giant explicitly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41383
Build 38272: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sep 5 2021, 3:35 AM

imp created this revision.

Harbormaster completed remote builds in B41383: Diff 94678.Sep 5 2021, 3:35 AM

imp added reviewers: mav, jhb, • hselasky, markj, kib, bhughes, whu.Sep 5 2021, 3:41 AM

Looks good, but while at hyper-v I'd also do it for hv_pci_delete_device().

jhb accepted this revision.Nov 29 2021, 6:19 PM

jhb added a parent revision: D31833: newbus: add bus_topo_assert.

This revision is now accepted and ready to land.Nov 29 2021, 6:20 PM

jhb added a child revision: D33057: hda: Push giant / newbus topo lock down a layer.Nov 29 2021, 6:20 PM

Arguably, it is the strangest use of Giant from all code I ever see.

Closed by commit rGf581847a7277: hyperv: scanning locking is using the bus mtx (authored by imp). · Explain WhyDec 14 2021, 11:54 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGf581847a7277: hyperv: scanning locking is using the bus mtx.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

vmbus/

vmbus.c

29 lines

Diff 94678

View Options

sys/dev/hyperv/vmbus/vmbus.c

hyperv: scanning locking is using the bus mtxClosedPublicActions