Page MenuHomeFreeBSD
Differential D31554

linux(4): Fixup options value validation in linux_waitid().
ClosedPublic
Actions

Authored by dchagin on Aug 16 2021, 12:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 7:33 PM
Unknown Object (File)
Mon, Aug 10, 6:29 AM
Unknown Object (File)
Sat, Aug 8, 2:22 AM
Unknown Object (File)
Tue, Aug 4, 6:31 AM
Unknown Object (File)
Tue, Aug 4, 5:59 AM
Unknown Object (File)
Tue, Aug 4, 2:12 AM
Unknown Object (File)
Mon, Aug 3, 7:04 AM
Unknown Object (File)
Sun, Aug 2, 5:28 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
Linux Emulation
Commits
rG7df3421cb6e2: linux(4): Fixup options value validation in linux_waitid().
rGd7e1e138ec66: linux(4): Fixup options value validation in linux_waitid().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41059
Build 37948: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 16 2021, 12:15 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2021, 12:15 PM
dchagin requested review of this revision.Aug 16 2021, 12:15 PM
Harbormaster completed remote builds in B41059: Diff 93744.Aug 16 2021, 12:15 PM
dchagin added a reviewer: Linux Emulation.Aug 16 2021, 12:18 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin updated this revision to Diff 93749.Aug 16 2021, 2:06 PM

fix strange mismerge

Harbormaster completed remote builds in B41063: Diff 93749.Aug 16 2021, 2:06 PM
emaste added a parent revision: D31555: linux(4): Add support for __WALL wait option bit..Aug 16 2021, 3:14 PM
emaste accepted this revision.Aug 16 2021, 3:18 PM
emaste added a subscriber: emaste.

This is fine with me, although I wonder if it makes sense to do the check in linux_to_bsd_waitopts so the supported options are all in one place? But no objection from me if you prefer this.

sys/compat/linux/linux_misc.c
1094

Do we have to do anything to handle __WNOTHREAD?

This revision is now accepted and ready to land.Aug 16 2021, 3:18 PM
dchagin added a comment.Aug 16 2021, 3:53 PM
In D31554#711493, @emaste wrote:

This is fine with me, although I wonder if it makes sense to do the check in linux_to_bsd_waitopts so the supported options are all in one place? But no objection from me if you prefer this.

wait4 differs against waitid in options, see WEXITED

sys/compat/linux/linux_misc.c
1094

this will be the next change

Closed by commit rGd7e1e138ec66: linux(4): Fixup options value validation in linux_waitid(). (authored by dchagin). · Explain WhyMar 31 2022, 5:51 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGd7e1e138ec66: linux(4): Fixup options value validation in linux_waitid()..
dchagin added a commit: rG7df3421cb6e2: linux(4): Fixup options value validation in linux_waitid()..Jun 17 2022, 7:41 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
4 lines

Diff 93744

View Options

sys/compat/linux/linux_misc.c

Loading...