Page MenuHomeFreeBSD

linux(4): Fixup options value validation in linux_waitid().
AcceptedPublic

Authored by dchagin on Aug 16 2021, 12:15 PM.

Details

Reviewers
emaste
Group Reviewers
Linux Emulation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 41063
Build 37952: arc lint + arc unit

Event Timeline

emaste added a subscriber: emaste.

This is fine with me, although I wonder if it makes sense to do the check in linux_to_bsd_waitopts so the supported options are all in one place? But no objection from me if you prefer this.

sys/compat/linux/linux_misc.c
1094

Do we have to do anything to handle __WNOTHREAD?

This revision is now accepted and ready to land.Aug 16 2021, 3:18 PM

This is fine with me, although I wonder if it makes sense to do the check in linux_to_bsd_waitopts so the supported options are all in one place? But no objection from me if you prefer this.

wait4 differs against waitid in options, see WEXITED

sys/compat/linux/linux_misc.c
1094

this will be the next change