Page MenuHomeFreeBSD

linux(4): Fixup options value validation in linux_waitid().
ClosedPublic

Authored by dchagin on Aug 16 2021, 12:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 10:22 AM
Unknown Object (File)
Thu, Nov 27, 3:56 AM
Unknown Object (File)
Wed, Nov 26, 12:49 PM
Unknown Object (File)
Wed, Nov 26, 4:12 AM
Unknown Object (File)
Wed, Nov 26, 3:33 AM
Unknown Object (File)
Tue, Nov 25, 8:16 PM
Unknown Object (File)
Tue, Nov 25, 2:15 PM
Unknown Object (File)
Sat, Nov 22, 4:13 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: emaste.

This is fine with me, although I wonder if it makes sense to do the check in linux_to_bsd_waitopts so the supported options are all in one place? But no objection from me if you prefer this.

sys/compat/linux/linux_misc.c
1094

Do we have to do anything to handle __WNOTHREAD?

This revision is now accepted and ready to land.Aug 16 2021, 3:18 PM

This is fine with me, although I wonder if it makes sense to do the check in linux_to_bsd_waitopts so the supported options are all in one place? But no objection from me if you prefer this.

wait4 differs against waitid in options, see WEXITED

sys/compat/linux/linux_misc.c
1094

this will be the next change