Paths

Table of Contentst

Differential D31477

Enable SError exceptions in the kernel
ClosedPublic
Actions

Authored by andrew on Aug 9 2021, 5:00 PM.

Tags

None

Referenced Files

	F85434016: D31477.id.diff
	Thu, Jun 6, 12:48 AM

	Unknown Object (File)
	Fri, May 24, 12:58 AM

	Unknown Object (File)
	Fri, May 10, 5:39 AM

	Unknown Object (File)
	May 7 2024, 1:14 AM

	Unknown Object (File)
	Apr 27 2024, 2:00 PM

	Unknown Object (File)
	Apr 3 2024, 12:11 AM

	Unknown Object (File)
	Dec 20 2023, 5:26 AM

	Unknown Object (File)
	Dec 14 2023, 10:00 PM

View All 32 Files

Subscribers

Details

Reviewers

kib
markj
mhorne
manu

Group Reviewers

Commits

rG9a83fcad145c: Enable arm64 SError exceptions in the kernel
rG17b6ee961382: Enable arm64 SError exceptions in the kernel

Summary

These are needed to signal to the kernel when a Reliability,
Availability, and Serviceability (RAS) exception has triggered.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40948
Build 37837: arc lint + arc unit

Event Timeline

andrew created this revision.Aug 9 2021, 5:00 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 9 2021, 5:00 PM

Herald added a subscriber: imp. · View Herald Transcript

andrew requested review of this revision.Aug 9 2021, 5:00 PM

Harbormaster completed remote builds in B40948: Diff 93447.Aug 9 2021, 5:00 PM

mhorne added inline comments.Aug 9 2021, 5:46 PM

sys/arm64/arm64/exception.S
88	Can an SError interrupt be taken from EL1? If so, I think you need to unmask DAIF_A here or in do_el1h_sync().
sys/arm64/arm64/machdep.c
943	Maybe add `serror_enable()` or similar to cpufunc.h and use that?

Unmask in the kernel
Add serror_enable

Harbormaster completed remote builds in B40962: Diff 93480.Aug 10 2021, 10:43 AM

mhorne accepted this revision.Aug 11 2021, 2:57 PM

This revision is now accepted and ready to land.Aug 11 2021, 2:57 PM

Closed by commit rG17b6ee961382: Enable arm64 SError exceptions in the kernel (authored by andrew). · Explain WhyAug 12 2021, 8:53 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG17b6ee961382: Enable arm64 SError exceptions in the kernel.

andrew added a commit: rG9a83fcad145c: Enable arm64 SError exceptions in the kernel.Sep 27 2021, 2:09 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

19 lines

6 lines

4 lines

include/

8 lines

Diff 93447

sys/arm64/arm64/exception.S

Loading...

sys/arm64/arm64/machdep.c

Loading...

sys/arm64/arm64/vm_machdep.c

Loading...

sys/arm64/include/armreg.h

Loading...