Differential D31418

pvclock: Add vDSO support
ClosedPublic
Actions

Authored by adam_fenn.io on Aug 5 2021, 2:29 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 8, 7:07 PM

	Unknown Object (File)
	Sat, Aug 8, 7:06 PM

	Unknown Object (File)
	Sat, Aug 8, 1:24 PM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

	Unknown Object (File)
	Fri, Aug 7, 2:33 AM

Subscribers

Details

Reviewers

kib
markj
stevek
royger

Commits

rG2a16b0f333d4: libc: vDSO timekeeping: Add pvclock support
rG4b34c91973dd: pvclock: Add vDSO support
rG249f2478e382: pvclock: Add 'struct pvclock' API
rGa3d932dfef5e: libc: vDSO timekeeping: Add pvclock support
rGd4b2d3035a23: pvclock: Add vDSO support
rG0b3382b863f3: pvclock: Add 'struct pvclock' API

Summary

Add vDSO support for timekeeping devices that support the KVM/XEN
paravirtual clock API.

Test Plan

Tested as part of testing D29733.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40862
Build 37751: arc lint + arc unit

Event Timeline

adam_fenn.io created this revision.Aug 5 2021, 2:29 AM

adam_fenn.io held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptAug 5 2021, 2:29 AM

Harbormaster completed remote builds in B40862: Diff 93247.Aug 5 2021, 2:29 AM

adam_fenn.io added a child revision: D29733: kvmclock driver with vDSO support.Aug 5 2021, 2:43 AM

adam_fenn.io published this revision for review.Aug 5 2021, 2:46 AM

markj added inline comments.Aug 5 2021, 2:08 PM

sys/x86/x86/pvclock.c

Should it (formally) be atomic_cmpset_rel_64?

Could this be written more simply as:

ret = now;
if ((flags & PVCLOCK_FLAG_TSC_STABLE) == 0) {
    last = atomic_load_acq_64(&pvclock_last_systime);
    do {
        if (last > now) {
            ret = last;
            break;
        }
    } while (!atomic_fcmpset_64(&pvclock_last_systime, &last, now);
}

?

Address @markj's feedback.

Harbormaster completed remote builds in B40879: Diff 93292.Aug 5 2021, 10:53 PM

adam_fenn.io marked 2 inline comments as done.Aug 5 2021, 10:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2021, 12:59 PM

Closed by commit rG0b3382b863f3: pvclock: Add 'struct pvclock' API (authored by adam_fenn.io, committed by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG0b3382b863f3: pvclock: Add 'struct pvclock' API.

kib added a commit: rGd4b2d3035a23: pvclock: Add vDSO support.

kib added a commit: rGa3d932dfef5e: libc: vDSO timekeeping: Add pvclock support.

kib added a commit: rG249f2478e382: pvclock: Add 'struct pvclock' API.Oct 12 2021, 4:04 PM

kib added a commit: rG4b34c91973dd: pvclock: Add vDSO support.

kib added a commit: rG2a16b0f333d4: libc: vDSO timekeeping: Add pvclock support.

Revision Contents
Changeset List

Path

Size

lib/

libc/

x86/

sys/

63 lines

sys/

dev/

acpica/

4 lines

hyperv/

vmbus/

amd64/

hyperv_machdep.c

2 lines

x86/

include/

89 lines

5 lines

x86/

342 lines

4 lines

Diff 93247

lib/libc/x86/sys/__vdso_gettc.c

Loading...

sys/dev/acpica/acpi_hpet.c

Loading...

sys/dev/hyperv/vmbus/amd64/hyperv_machdep.c

Loading...

sys/x86/include/pvclock.h

Loading...

sys/x86/include/vdso.h

Loading...

sys/x86/x86/pvclock.c

Loading...

sys/x86/x86/tsc.c

Loading...