Page MenuHomeFreeBSD
Differential D31058

Don't build and install {llvm,clang,lldb}-tblgen for the target
ClosedPublic
Actions

Authored by arichardson on Jul 5 2021, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 10:03 AM
Unknown Object (File)
Fri, Nov 8, 9:06 PM
Unknown Object (File)
Fri, Nov 8, 7:37 PM
Unknown Object (File)
Oct 23 2024, 8:39 AM
Unknown Object (File)
Oct 22 2024, 6:08 AM
Unknown Object (File)
Oct 17 2024, 6:13 PM
Unknown Object (File)
Oct 7 2024, 10:40 PM
Unknown Object (File)
Oct 4 2024, 11:26 PM
View All Files
Subscribers
imp
jrtc27

Details

Reviewers
dim
emaste
Commits
rG5761fecb4ee3: Don't build and install {llvm,clang,lldb}-tblgen for the target
rG5814e2ba97a1: Don't build and install {llvm,clang,lldb}-tblgen for the target
rG8e1c989abbd1: Don't build and install {llvm,clang,lldb}-tblgen for the target
Summary

The tablegen binaries are only needed to build software that uses
LLVM's infrastructure for command line options,
disassembler tables, etc. They are not user-facing binaries and
should therefore not be installed by default.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Errors
SeverityLocationCodeMessage
Errortools/build/make.py:122E302PEP8 E302
Errortools/build/make.py:132E302PEP8 E302
Errortools/build/make.py:259E501PEP8 E501
Unit
No Test Coverage
Build Status
Buildable 40539
Build 37428: arc lint + arc unit

Event Timeline

arichardson created this revision.Jul 5 2021, 5:22 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 5 2021, 5:22 PM
arichardson requested review of this revision.Jul 5 2021, 5:22 PM
Harbormaster completed remote builds in B40313: Diff 91811.Jul 5 2021, 5:22 PM
arichardson added a child revision: D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.Jul 5 2021, 5:45 PM
arichardson added a comment.Jul 19 2021, 12:40 PM

ping?

emaste added a comment.Jul 19 2021, 1:36 PM

Fine with me, assuming these are built using a different mechanism for the build toolchain itself.

arichardson updated this revision to Diff 92442.Jul 19 2021, 10:36 PM
arichardson added a subscriber: jrtc27.

Address latest @jrtc27 feedback

Harbormaster completed remote builds in B40539: Diff 92442.Jul 19 2021, 10:36 PM
arichardson added a comment.Jul 19 2021, 10:37 PM

sorry accidentally updated the wrong review.

arichardson updated this revision to Diff 92444.Jul 19 2021, 10:41 PM

restore previous revision

Harbormaster completed remote builds in B40541: Diff 92444.Jul 19 2021, 10:41 PM
arichardson added a comment.Aug 2 2021, 1:40 PM

@dim does this look okay?

emaste accepted this revision.Aug 6 2021, 3:22 PM
This revision is now accepted and ready to land.Aug 6 2021, 3:22 PM
dim added a comment.Aug 6 2021, 5:07 PM

While this is OK, I think we may even consider to avoid installing any of the tblgen tools *at all* in the base system. Other "extras" tools like llc, llvm-mc etc are usable by themselves, whereas the tblgen tools are really only needed for building llvm-project components.

That said, can you also add an entry to OptionalObsoleteFiles.inc for these? So they get cleaned up everybody that has MK_CLANG_EXTRAS=no.

arichardson updated this revision to Diff 93736.Aug 16 2021, 8:27 AM

don't install the tools at all

This revision now requires review to proceed.Aug 16 2021, 8:27 AM
Harbormaster completed remote builds in B41055: Diff 93736.Aug 16 2021, 8:27 AM
arichardson retitled this revision from Only build {llvm,clang,lldb}-tblgen for the target with MK_CLANG_EXTRAS to Don't build and install {llvm,clang,lldb}-tblgen for the target.Aug 16 2021, 8:29 AM
arichardson edited the summary of this revision. (Show Details)
arichardson added a parent revision: D31531: Fix bootstrapping to actually build lldb-tblgen for later use.Aug 16 2021, 8:32 AM
arichardson added a comment.Aug 26 2021, 9:23 AM

ping @dim ?

ObsoleteFiles.inc
43 ↗(On Diff #93736)

will update date prior to committing.

emaste accepted this revision.Aug 30 2021, 3:34 PM

LGTM

This revision is now accepted and ready to land.Aug 30 2021, 3:34 PM
Closed by commit rG8e1c989abbd1: Don't build and install {llvm,clang,lldb}-tblgen for the target (authored by arichardson). · Explain WhySep 6 2021, 9:25 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG8e1c989abbd1: Don't build and install {llvm,clang,lldb}-tblgen for the target.
dim added a commit: rG5814e2ba97a1: Don't build and install {llvm,clang,lldb}-tblgen for the target.Dec 5 2021, 8:58 PM
dim added a commit: rG5761fecb4ee3: Don't build and install {llvm,clang,lldb}-tblgen for the target.Dec 25 2021, 11:57 AM

Revision Contents
Changeset List

PathSize
lib/
clang/
include/
llvm/
Config/
2 lines
1 line
tools/
build/
2 lines
usr.bin/
clang/
10 lines
2 lines
lld/
2 lines
2 lines

Diff 92442

View Options

lib/clang/include/llvm/Config/config.h

Loading...
View Options

lib/clang/llvm.build.mk

Loading...
View Options

tools/build/make.py

Loading...
View Options

usr.bin/clang/Makefile

Loading...
View Options

usr.bin/clang/clang.prog.mk

Loading...
View Options

usr.bin/clang/lld/Makefile

Loading...
View Options

usr.bin/clang/llvm.prog.mk

Loading...