Looks good. You can use {L:} for strings that include slashes by escaping them with double backslashes (one for C, one for me):

xo_emit("{Lc:Warn\\/full granularity}{P:\t}{:granularity-wf/%d}{Uw:/%sh}\n", ...

Thanks,
Phil

FYI: I've just added docs for this, so it will be in the next release, which I'll import shortly, but the functionality's already there.

Thanks,
Phil

In D30350#681699, @me_cameronkatri.com wrote:

Run xo_finish(3) after all instances of xo_errx(3)

xo_errx doesn't return; no further calls are needed/possible.

FWIW xo_errx() calls xo_finish() before calling exit().

Thanks,
Phil

In D30350#687708, @phil wrote:

In D30350#681699, @me_cameronkatri.com wrote:

Run xo_finish(3) after all instances of xo_errx(3)

xo_errx doesn't return; no further calls are needed/possible.

FWIW xo_errx() calls xo_finish() before calling exit().

Thanks,
Phil

However if you don’t encounter any errors you still need to run xo_finish(3).

• Cameron

In D30350#687688, @phil wrote:

Looks good. You can use {L:} for strings that include slashes by escaping them with double backslashes (one for C, one for me):

xo_emit("{Lc:Warn\\/full granularity}{P:\t}{:granularity-wf/%d}{Uw:/%sh}\n", ...

Thanks,
Phil

I could swear I tried this, I’ll update the patch shortly.

• Cameron

In D30350#687710, @me_cameronkatri.com wrote:

I could swear I tried this, I’ll update the patch shortly.

Well, retest to ensure I'm not lying, but I just verified it as working in libxo/develop and even added an explicit test case for it, as well as docs.

Thanks,
Phil

In D30350#687753, @phil wrote:

In D30350#687710, @me_cameronkatri.com wrote:

I could swear I tried this, I’ll update the patch shortly.

Well, retest to ensure I'm not lying, but I just verified it as working in libxo/develop and even added an explicit test case for it, as well as docs.

Thanks,
Phil

I checked it already, and it worked.

• Cameron

Yes, you need to check it. See xo_parse_args(3):

       On failure, a message it emitted and -1 is returned.

	       argc = xo_parse_args(argc, argv);
	       if (argc < 0)
		   exit(EXIT_FAILURE);

Cameron,

You said "it seems that most check"; did you find ones that didn't?

Thanks,
Phil

In D30350#714235, @phil wrote:

Cameron,

You said "it seems that most check"; did you find ones that didn't?

Thanks,
Phil

I found one that doesn't check argc: procstat(1).

Manual page change LGTM.

Sorry to bother, but was just wondering if someone could review this as it's been stale for a while.

Good morning, what's the status on getting this landed?

Sorry for the delay.

Thanks,
Phil

Is there some reason that this didn't land?