cxgbe: set iq flags only after it has been initialized
ClosedPublic
Actions

Authored by gallatin on May 25 2021, 9:39 PM.

Details

Reviewers

np
jhb
rrs

Commits

rG3aad5b1fe251: cxgbe: fix enabling lro & rxtimestamps
rG392d7f026962: cxgbe: fix enabling lro & rxtimestamps
rGdf8437a93dd5: cxgbe: fix enabling lro & rxtimestamps

Summary

Recent changes caused iq flags, like LRO, to be set before init_iq(). However, init_iq() clears those flags, so they are effectively impossible to set now. This prevented LRO from working for us.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gallatin created this revision.May 25 2021, 9:39 PM

Herald added a subscriber: ae. · View Herald TranscriptMay 25 2021, 9:39 PM

gallatin requested review of this revision.May 25 2021, 9:39 PM

Thanks for the fix. Please add a "Fixes: 43bbae19483fbde0a91e61acad8a6e71e334c8b8" line to the commit log before checking it in.

This revision is now accepted and ready to land.May 25 2021, 11:55 PM

rrs accepted this revision.May 26 2021, 10:23 AM

Closed by commit rGdf8437a93dd5: cxgbe: fix enabling lro & rxtimestamps (authored by gallatin). · Explain WhyMay 26 2021, 2:04 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rGdf8437a93dd5: cxgbe: fix enabling lro & rxtimestamps.

np added a commit: rG392d7f026962: cxgbe: fix enabling lro & rxtimestamps.Apr 4 2022, 7:04 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 4 2022, 7:04 PM

np added a commit: rG3aad5b1fe251: cxgbe: fix enabling lro & rxtimestamps.Apr 4 2022, 8:58 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

t4_sge.c

11 lines

Diff 89901

View Options

cxgbe: set iq flags only after it has been initializedClosedPublicActions