Differential D29207

Set TDP_KTHREAD before calling cpu_fork() and cpu_copy_thread().
ClosedPublic
Actions

Authored by jhb on Mar 10 2021, 10:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 15, 11:59 AM

	Unknown Object (File)
	Sat, Aug 15, 11:51 AM

	Unknown Object (File)
	Sat, Aug 15, 11:51 AM

	Unknown Object (File)
	Sat, Aug 15, 11:41 AM

	Unknown Object (File)
	Wed, Aug 5, 5:54 AM

	Unknown Object (File)
	Wed, Aug 5, 4:13 AM

	Unknown Object (File)
	Tue, Aug 4, 6:08 AM

	Unknown Object (File)
	Fri, Jul 31, 12:56 PM

Subscribers

Details

Reviewers

Commits

rG640d54045bdb: Set TDP_KTHREAD before calling cpu_fork() and cpu_copy_thread().

Summary

This permits these routines to use special logic for initializing MD
kthread state.

For the kproc case, this required moving the logic to set these flags
from kproc_create() into do_fork().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 10 2021, 10:13 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 10 2021, 10:13 PM

jhb requested review of this revision.Mar 10 2021, 10:13 PM

jhb added a parent revision: D29206: Don't pass RFPROC to kproc_create(), it is redundant..

jhb added a child revision: D29208: x86: Always use clean FPU and segment base state for new kthreads..

Harbormaster completed remote builds in B37752: Diff 85522.Mar 10 2021, 10:14 PM

kib added inline comments.Mar 11 2021, 5:22 AM

sys/kern/kern_fork.c
509	Note that code for DROPSIG_CAUGHT above is accurate to lock p2 ps_mtx around p_sigacts manipulations (even if only for asserts). I think it is better to be consistent both by style and formal requirements and lock ps_mtx if (FR2_DROPSIG_CAUGHT \| FR2_KPROC).

Review feedback.

Harbormaster completed remote builds in B37785: Diff 85603.Mar 11 2021, 10:34 PM

jhb marked an inline comment as done.Mar 11 2021, 10:36 PM

kib accepted this revision.Mar 12 2021, 12:46 PM

This revision is now accepted and ready to land.Mar 12 2021, 12:46 PM

Closed by commit rG640d54045bdb: Set TDP_KTHREAD before calling cpu_fork() and cpu_copy_thread(). (authored by jhb). · Explain WhyMar 12 2021, 5:51 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG640d54045bdb: Set TDP_KTHREAD before calling cpu_fork() and cpu_copy_thread()..

Revision Contents
Changeset List

Path

Size

sys/

kern/

12 lines

17 lines

sys/

1 line

Diff 85654

sys/kern/kern_fork.c

Loading...

sys/kern/kern_kthread.c

Loading...

sys/sys/proc.h

Loading...