iflib: add support for admin completion queues
ClosedPublic
Actions

Authored by ar_semihalf.com on Feb 16 2021, 5:26 PM.

Details

Reviewers

mmacy
gallatin
mw
shurd

Group Reviewers

iflib

Commits

rG09c3f04ff3be: iflib: add support for admin completion queues

Summary

For interfaces with admin completion queues, introduce a new devmethod
IFDI_ADMIN_COMPLETION_HANDLE and a corresponding flag IFLIB_HAS_ADMINCQ.

This provides an option for handling any admin cq logic, which cannot be
run from an interrupt context.

Said method is called from within iflib's admin task, making it safe to
sleep.

Submitted by: Artur Rojek <ar@semihalf.com>
Obtained from: Semihalf
Sponsored by: Amazon, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ar_semihalf.com created this revision.Feb 16 2021, 5:26 PM

Herald added a reviewer: shurd. · View Herald TranscriptFeb 16 2021, 5:26 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: melifaro, ae. · View Herald Transcript

ar_semihalf.com requested review of this revision.Feb 16 2021, 5:26 PM

Reconsider turning the devmethod into an admin completion queue specific handler, which both reduces the scope of the call and makes the usecase more obvious.

To clarify on the usecase in the Amazon ENA driver, we need to handle any admin completion queues, not just asynchronous event ones, in a sleep safe context.

It’s in a non performance critical path with no side effects if not used, so worst case it’s not useful to other consumers.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2021, 11:41 PM

Closed by commit rG09c3f04ff3be: iflib: add support for admin completion queues (authored by mw). · Explain Why

This revision was automatically updated to reflect the committed changes.

mw added a commit: rG09c3f04ff3be: iflib: add support for admin completion queues.