Do not reference returned ifa in in6_ifawithifp().
ClosedPublic
Actions

Authored by melifaro on Feb 13 2021, 3:59 PM.

Details

Reviewers

Group Reviewers

Commits

rG3cff9b2ccfd0: Do not reference returned ifa in in6_ifawithifp().
rG1bd44b11e59f: Do not reference returned ifa in in6_ifawithifp().

Summary

The only place where in6_ifawithifp() is used is ip6_output(), which uses the returned ifa to bump traffic counters.
Given ifa stability guarantees is provided by epoch, do not refcount ifa.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36970
Build 33859: arc lint + arc unit

Event Timeline

melifaro created this revision.Feb 13 2021, 3:59 PM

Herald added subscribers: bz, ae, imp. · View Herald TranscriptFeb 13 2021, 3:59 PM

melifaro requested review of this revision.Feb 13 2021, 3:59 PM

melifaro edited the summary of this revision. (Show Details)Feb 13 2021, 4:00 PM

melifaro added a reviewer: network.

Harbormaster completed remote builds in B36970: Diff 83834.Feb 13 2021, 4:00 PM

rstone accepted this revision.Feb 14 2021, 4:13 AM

This revision is now accepted and ready to land.Feb 14 2021, 4:13 AM

Closed by commit rG1bd44b11e59f: Do not reference returned ifa in in6_ifawithifp(). (authored by melifaro). · Explain WhyFeb 14 2021, 10:13 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG1bd44b11e59f: Do not reference returned ifa in in6_ifawithifp()..

melifaro added a commit: rG3cff9b2ccfd0: Do not reference returned ifa in in6_ifawithifp()..Mar 10 2021, 10:28 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

in6.c

14 lines

ip6_output.c

1 line

Diff 83834

View Options

sys/netinet6/in6.c