Follow-up to r353959 and r368070: do the same for other architectures.
arm32 already seems to use its own .fnstart/.fnend directives, which
appear to be ARM-specific variants of the same thing. Likewise, MIPS
uses .frame directives.
Details
Details
Tinderbox running.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 35063 Build 32038: arc lint + arc unit
Event Timeline
| sys/powerpc/include/asm.h | ||
|---|---|---|
| 163 | Currently there's no .size directive for powerpc32, unlike powerpc64. There's an END_SIZE macro available for that, though it looks like it's assuming powerpc64 without checking so you might want to just do a normal .size. | |
| sys/powerpc/include/asm.h | ||
|---|---|---|
| 163 | Sure, I'll add it. Thanks. | |
Comment Actions
Add a lot of missing END directives. Tinderbox passes on arm64 and i386.
PowerPC mostly passes, except for all the PS3 HV calls which still need END
directives (and there are hundreds of these).
Comment Actions
Are there any outstanding objections? (I think I've addressed everything raised so far, but please correct me if I am mistaken.) Is there anyone who hasn't reviewed yet, but will have time to review in the next few days? Thanks.
Comment Actions
Looks good to me. Obviously there might be some non-default build configurations that are missing end() calls, but if so they been be fixed later.
Probably best to wait for at least one more review though.
Comment Actions
I'm fine with it on readthrough, I just hadn't gotten around to the actual tests. If it broke anything in powerpc land, it should be easy to fix. Thanks for tidying up the procedure annotations!
Comment Actions
Thanks! It compiles (tinderbox, anyway) and shouldn't affect code generation, so I'm cautiously optimistic nothing broke. Please let me know if it broke something and I can help fix it :-).