Include TMPFS in all the GENERIC kernel configs
ClosedPublic
Actions

Authored by arichardson on Jun 17 2020, 11:18 AM.

Details

Reviewers

jrtc27
mhorne
jhb
br
manu
delphij
brooks
emaste

Group Reviewers

riscv

Commits

rS363471: Include TMPFS in all the GENERIC kernel configs

Summary

Being able to use tmpfs without kernel modules is very useful when building
small MFS_ROOT kernels without a real file system.
Including TMPFS also matches arm/GENERIC and the MIPS std.MALTA configs.

Compiling TMPFS only adds 4 .c files so this should not make much of a
difference to NO_MODULES build times (as we do for our minimal RISC-V
images).

Test Plan

I can now create /tmp as a tmpfs mount on a kernel without modules.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31766
Build 29332: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Jun 17 2020, 11:18 AM

arichardson created this revision.

arichardson added a reviewer: br.Jun 17 2020, 10:31 PM

Harbormaster completed remote builds in B31766: Diff 73218.Jun 18 2020, 9:19 AM

br accepted this revision.Jun 18 2020, 9:26 AM

This revision is now accepted and ready to land.Jun 18 2020, 9:26 AM

Why are we doing this for GENERIC? No other architecture does so, and the only differences between them for GENERIC should be genuinely architecture-specific things, which TMPFS is not. If you want it for MFSROOT kernels, limit it to those. GENERIC is supposed to pick it up as a module just like everything else not required during earlyish boot.

This revision now requires changes to proceed.Jun 18 2020, 10:35 AM

In D25317#558618, @jrtc27 wrote:

Why are we doing this for GENERIC? No other architecture does so, and the only differences between them for GENERIC should be genuinely architecture-specific things, which TMPFS is not. If you want it for MFSROOT kernels, limit it to those. GENERIC is supposed to pick it up as a module just like everything else not required during earlyish boot.

arm/GENERIC has include "std.armv7" which enables TMPFS

In D25317#558621, @arichardson wrote:

In D25317#558618, @jrtc27 wrote:

Why are we doing this for GENERIC? No other architecture does so, and the only differences between them for GENERIC should be genuinely architecture-specific things, which TMPFS is not. If you want it for MFSROOT kernels, limit it to those. GENERIC is supposed to pick it up as a module just like everything else not required during earlyish boot.

arm/GENERIC has include "std.armv7" which enables TMPFS

True, and perhaps for similar reasons of being used on (somewhat-)embedded devices. Honestly I don't know why it _isn't_ always compiled in.

In D25317#559146, @jrtc27 wrote:

In D25317#558621, @arichardson wrote:

In D25317#558618, @jrtc27 wrote:

Why are we doing this for GENERIC? No other architecture does so, and the only differences between them for GENERIC should be genuinely architecture-specific things, which TMPFS is not. If you want it for MFSROOT kernels, limit it to those. GENERIC is supposed to pick it up as a module just like everything else not required during earlyish boot.

arm/GENERIC has include "std.armv7" which enables TMPFS

True, and perhaps for similar reasons of being used on (somewhat-)embedded devices. Honestly I don't know why it _isn't_ always compiled in.

Yeah it's like 3 .c files. I can try adding it to the other GENERIC kernels, but I'm not sure who to add to that review.

Add TMPFS to all kernel configs instead

Herald added a reviewer: manu. · View Herald TranscriptJul 14 2020, 10:47 AM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B32316: Diff 74434.Jul 14 2020, 10:47 AM

arichardson retitled this revision from Include TMPFS in the RISC-V GENERIC kernel to Include TMPFS in all the GENERIC kernel configs.Jul 14 2020, 10:48 AM

arichardson edited the summary of this revision. (Show Details)

arichardson added a reviewer: delphij.

emaste added a subscriber: kib.Jul 15 2020, 1:22 AM

ping?

arichardson added a reviewer: brooks.Jul 23 2020, 9:01 PM