Details

Reviewers

mw
manu
• ian

Group Reviewers

ARM
arm64

Commits

rS361461: Introduce VF610 I2C controller support.

Summary

NXP LS1046A contains I2C controller compatible with Vybrid VF610.
Existing Vybrid MVF600 driver can be used to support it. For that purpose
declare driver as ofw_iicbus and add methods associated with ofw_iicbus.

For VF610 add dynamic clock prescaler calculation using clock information
from clock driver and clock frequency requested in device tree.

On the occasion add detach function and add additional error handling
in i2c_attach function.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dgr_semihalf.com created this revision.Apr 10 2020, 11:12 AM

Herald added subscribers: emaste, andrew. · View Herald TranscriptApr 10 2020, 11:12 AM

dgr_semihalf.com added a parent revision: D24353: Add GPIO support for QorIQ boards..Apr 10 2020, 11:13 AM

manu added inline comments.Apr 10 2020, 11:33 AM

sys/arm/freescale/vybrid/vf_i2c.c
250	Missing call to bus_release_resources

manu added a reviewer: • ian.Apr 10 2020, 11:40 AM

manu added reviewers: ARM, arm64.Apr 10 2020, 11:43 AM

andrew added inline comments.Apr 10 2020, 6:18 PM

sys/conf/files.arm64
109	This should have a driver specific option. We may want `iicbus` enabled, but not this driver.

Added bus_release_resources call and dependency on SOC_NXP_LS1046A.

manu added inline comments.Apr 30 2020, 7:47 PM

sys/arm/freescale/vybrid/vf_i2c.c
192	Can the driver work if there is no clock ? Since you set sc->freq below I'm not sure it can.
sys/conf/files.arm64
109	That should be optional <driver_name> iicbus SOC_NXP_LS1046A

dgr_semihalf.com added inline comments.May 7 2020, 11:04 AM

sys/arm/freescale/vybrid/vf_i2c.c
192	The driver can work without clock - when no clock is found it uses the highest possible prescaler value for VF610. For MVF600 the way driver originally worked is preserved.