Page MenuHomeFreeBSD

vmx: use C99 bool, not boolean_t
ClosedPublic

Authored by emaste on Jul 23 2019, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 31 2024, 12:53 AM
Unknown Object (File)
Jan 31 2024, 12:53 AM
Unknown Object (File)
Jan 31 2024, 12:53 AM
Unknown Object (File)
Jan 19 2024, 12:41 AM
Unknown Object (File)
Dec 25 2023, 12:18 PM
Unknown Object (File)
Dec 20 2023, 7:45 AM
Unknown Object (File)
Dec 19 2023, 4:10 PM
Unknown Object (File)
Dec 12 2023, 7:53 AM

Details

Summary

Bhyve's vmm is a self-contained modern component and thus a good candidate for use of C99 types.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Jul 23 2019, 1:55 PM
sys/amd64/vmm/intel/vmx_msr.c
53

I would use the opportunity and write

return ((msr_var & (1UL << (bitpos + 32)) != 0);
60

Same.

92

Same.

sys/amd64/vmm/vmm_lapic.c
142–143

return (msr >= 0x800 && msr <= 0xBFF);

158

Same.

sys/amd64/vmm/vmm_util.c
46

return (strcmp(...) == 0);

52

Same.

Simplify some boolean conditionals per kib

This revision now requires review to proceed.Jul 23 2019, 2:27 PM
This revision is now accepted and ready to land.Jul 23 2019, 2:29 PM
sys/amd64/vmm/vmm.c
2239

bool found

sys/amd64/vmm/vmm_lapic.c
157

Extra () on the right side of ||.

This revision now requires review to proceed.Jul 23 2019, 3:08 PM

Looks good, with all of @kib's comments addressed.

This revision is now accepted and ready to land.Jul 23 2019, 3:12 PM
This revision was automatically updated to reflect the committed changes.