vmx: use C99 bool, not boolean_t

[emaste]

Summary

Bhyve's vmm is a self-contained modern component and thus a good candidate for use of C99 types.

[emaste]

upload correct diff

[kib]

sys/amd64/vmm/intel/vmx_msr.c

56 ↗

(On Diff #60043)

I would use the opportunity and write

return ((msr_var & (1UL << (bitpos + 32)) != 0);

66 ↗

(On Diff #60043)

Same.

101 ↗

(On Diff #60043)

Same.

sys/amd64/vmm/vmm_lapic.c

143 ↗

(On Diff #60043)

return (msr >= 0x800 && msr <= 0xBFF);

164 ↗

(On Diff #60043)

Same.

sys/amd64/vmm/vmm_util.c

49 ↗

(On Diff #60043)

return (strcmp(...) == 0);

58 ↗

(On Diff #60043)

Same.

[emaste]

Simplify some boolean conditionals per kib

[kib]

sys/amd64/vmm/vmm.c

2239 ↗

(On Diff #60044)

bool found

sys/amd64/vmm/vmm_lapic.c

157 ↗

(On Diff #60044)

Extra () on the right side of ||.

[emaste]

further updates from kib

[pmooney_pfmooney.com]

Looks good, with all of @kib's comments addressed.