Page MenuHomeFreeBSD
Differential D21036

vmx: use C99 bool, not boolean_t
ClosedPublic
Actions

Authored by emaste on Jul 23 2019, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 24 2024, 11:17 PM
Unknown Object (File)
Nov 18 2024, 10:08 PM
Unknown Object (File)
Nov 10 2024, 3:50 AM
Unknown Object (File)
Nov 7 2024, 12:22 AM
Unknown Object (File)
Oct 6 2024, 8:58 PM
Unknown Object (File)
Oct 6 2024, 2:48 PM
Unknown Object (File)
Oct 5 2024, 8:45 PM
Unknown Object (File)
Oct 5 2024, 6:08 AM
View All 85 Files
Subscribers
andrew
bcran
imp
kib
pmooney_pfmooney.com
rgrimes

Details

Reviewers
jhb
manu
markj
pmooney_pfmooney.com
kib
Group Reviewers
bhyve
Commits
rS350492: vmx: use C99 bool, not boolean_t
Summary

Bhyve's vmm is a self-contained modern component and thus a good candidate for use of C99 types.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Jul 23 2019, 1:48 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 23 2019, 1:48 PM
Herald added a subscriber: andrew. · View Herald Transcript
emaste updated this revision to Diff 60043.Jul 23 2019, 1:50 PM

upload correct diff

Herald added a reviewer: bhyve. · View Herald TranscriptJul 23 2019, 1:50 PM
Herald added subscribers: bcran, rgrimes. · View Herald Transcript
markj accepted this revision as: markj.Jul 23 2019, 1:55 PM
This revision is now accepted and ready to land.Jul 23 2019, 1:55 PM
kib added inline comments.Jul 23 2019, 2:10 PM
sys/amd64/vmm/intel/vmx_msr.c
56

I would use the opportunity and write

return ((msr_var & (1UL << (bitpos + 32)) != 0);
66

Same.

101

Same.

sys/amd64/vmm/vmm_lapic.c
143

return (msr >= 0x800 && msr <= 0xBFF);

164

Same.

sys/amd64/vmm/vmm_util.c
49

return (strcmp(...) == 0);

58

Same.

emaste updated this revision to Diff 60044.Jul 23 2019, 2:27 PM

Simplify some boolean conditionals per kib

This revision now requires review to proceed.Jul 23 2019, 2:27 PM
markj accepted this revision as: markj.Jul 23 2019, 2:29 PM
This revision is now accepted and ready to land.Jul 23 2019, 2:29 PM
kib added inline comments.Jul 23 2019, 2:51 PM
sys/amd64/vmm/vmm.c
2239

bool found

sys/amd64/vmm/vmm_lapic.c
163

Extra () on the right side of ||.

emaste updated this revision to Diff 60047.Jul 23 2019, 3:08 PM

further updates from kib

This revision now requires review to proceed.Jul 23 2019, 3:08 PM
pmooney_pfmooney.com accepted this revision.Jul 23 2019, 3:12 PM
pmooney_pfmooney.com added a subscriber: pmooney_pfmooney.com.

Looks good, with all of @kib's comments addressed.

This revision is now accepted and ready to land.Jul 23 2019, 3:12 PM
kib accepted this revision.Jul 23 2019, 3:15 PM
jhb accepted this revision.Jul 31 2019, 10:53 PM
Closed by commit rS350492: vmx: use C99 bool, not boolean_t (authored by emaste). · Explain WhyAug 1 2019, 2:17 AM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS350492: vmx: use C99 bool, not boolean_t.
Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 2:17 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
6 lines
vmm/
intel/
10 lines
18 lines
io/
2 lines
6 lines
24 lines
2 lines
12 lines
6 lines
18 lines

Diff 60043

View Options

sys/amd64/include/vmm.h

Loading...
View Options

sys/amd64/vmm/intel/vmx.c

Loading...
View Options

sys/amd64/vmm/intel/vmx_msr.c

Loading...
View Options

sys/amd64/vmm/io/ppt.h

Loading...
View Options

sys/amd64/vmm/io/ppt.c

Loading...
View Options

sys/amd64/vmm/vmm.c

Loading...
View Options

sys/amd64/vmm/vmm_lapic.h

Loading...
View Options

sys/amd64/vmm/vmm_lapic.c

Loading...
View Options

sys/amd64/vmm/vmm_util.h

Loading...
View Options

sys/amd64/vmm/vmm_util.c

Loading...