For any future uploads please include full context (e.g. from git diff -U9999 or equivalent).

I believe at least some of these should be addressed by fixing whatever failed rather than by excluding parts from the build; do you have a list of the errors you encountered with the various combinations? i.e., I would be interested in seeing how ping and dhclient fail under DYNAMICROOT.

For any future uploads please include full context (e.g. from git diff -U9999 or equivalent).

And from SVN?

I'll post the errors!

I believe at least some of these should be addressed by fixing whatever failed rather than by excluding parts from the build; do you have a list of the errors you encountered with the various combinations? i.e., I would be interested in seeing how ping and dhclient fail under DYNAMICROOT.

From a separate "build option survey" build of WITHOUT_DYNAMICROOT:

• all_subdir_secure ---

cc -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/src/tools/tools/bui
ld_option_survey/_.tst/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/tools/tools/bu
ild_option_survey/_.tst/usr/src/amd64.amd64/tmp/usr/bin -pg -O2 -pipe -I/usr/
src/crypto/openssl -DTERMIOS -DANSI_SOURCE -DOPENSSL_THREADS -DDSO_DLFCN -DHAVE_
DLFCN_H -DL_ENDIAN -DOPENSSL_IA32_SSE2 -DAES_ASM -DBSAES_ASM -DVPAES_ASM -DECP_N
ISTZ256_ASM -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -
DMD5_ASM -DGHASH_ASM -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DWHIRLPOOL_ASM -I/usr
/obj/usr/src/tools/tools/build_option_survey/_.tst/usr/src/amd64.amd64/secure/li
b/libcrypto -I/usr/src/crypto/openssl/crypto -I/usr/src/crypto/openssl/crypto/as
n1 -I/usr/src/crypto/openssl/crypto/evp -I/usr/src/crypto/openssl/crypto/modes -
g -MD -MF.depend.x509_cmp.po -MTx509_cmp.po -std=gnu89 -fstack-protector-strong
-Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variab
le -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-un
used-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-pac
ked-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parenth
eses -Qunused-arguments -c /usr/src/crypto/openssl/crypto/x509/x509_cmp.c -o x
509_cmp.po

• all_subdir_sbin ---

cc: error: linker command failed with exit code 1 (use -v to see invocation)

• [dhclient.full] Error code 1

make[4]: stopped in /usr/src/sbin/dhclient

emaste,

From another 12.0-ALPHA4 build:

• all_subdir_bin ---

objcopy --only-keep-debug expr.full expr.debug

• all_subdir_lib ---

cc: error: linker command failed with exit code 1 (use -v to see invocation)

• all_subdir_bin ---

istine/share/colldef/../../tools/tools/locale/etc/final-maps/map.UTF-8 /usr/obj/
usr/srcpristine/amd64.amd64/share/colldef/ca_AD.UTF-8

• all_subdir_bin ---
• expr.1.gz ---

gzip -cn /usr/srcpristine/bin/expr/expr.1 > expr.1.gz

• all_subdir_sbin ---

/usr/bin/ld: error: unable to find library -lcasper

• all_subdir_lib ---
• e_gammaf.po ---
• all_subdir_sbin ---
• all_subdir_sbin/dhclient/tests ---
• option-domain-search_test ---

(cd /usr/srcpristine/sbin/dhclient/tests && DEPENDFILE=.depend.option-domain-se
arch_test NO_SUBDIR=1 make -f /usr/srcpristine/sbin/dhclient/tests/Makefile _RE
CURSING_PROGS=t PROG=option-domain-search_test )

• dhclient.full ---

/usr/bin/ld: error: unable to find library -lcap_syslog
cc: error: linker command failed with exit code 1 (use -v to see invocation)

• all_subdir_bin ---
• expr.debug ---
• all_subdir_sbin ---
• [dhclient.full] Error code 1

make[4]: stopped in /usr/srcpristine/sbin/dhclient

Ah,

/usr/bin/ld: error: unable to find library -lcap_syslog

casper services are only available as shared libraries.

Looking at dhclient's Makefile I see .if ${MK_CASPER} != "no" && !defined(RESCUE); we ought to incorporate MK_DYNAMICROOT into that as well. Something like

.if ${MK_DYNAMICROOT} == "no"
.warning dhclient built without libcasper support
.elif ${MK_CASPER} != "no" && !defined(RESCUE)
LIBADD+=        casper
...

Add @oshogbo for comment on the dhclient libcasper issue

I have split out the build option survey components and WITHOUT_DYNAMICROOT.

Huge thanks to rgrimes for getting the "BOS" patch reviewed and committed, and to emaste for posting a separate WITHOUT_DYNAMICROOT. patch that I have built and installed:

https://reviews.freebsd.org/D17074

I have removed both of those components from this diff.

WITHOUT_FILE, WITHOUT_CRYPT!OPENSSL and WITHOUT_INET* all are quite intertwined, with the possible exception of WITHOUT_FILE, though it applies to *SVN*, which in turn depends on OPENSSL and INET*

@emaste The part about Casper LGTM.

Some more comments inline - as mentioned earlier we should try to address the root causes, as in D17074. That said, I'm fine with this approach pending root cause fixes (given that it doesn't build today), but want to make sure we have some way to track these outstanding issues such that they'll get fixed after the release.

I should probably add that I never liked having two options, but it's been inherited from what we had (I think v6 had it and I did the same for legacy). But since our option space has been way too fine grained to my believe anyway for too many things, which is a totally different issue.

In D17040#364538, @emaste wrote:

Some more comments inline - as mentioned earlier we should try to address the root causes, as in D17074. That said, I'm fine with this approach pending root cause fixes (given that it doesn't build today), but want to make sure we have some way to track these outstanding issues such that they'll get fixed after the release.

I would prefer we only do the root cause fixes, as if we bypass the failing build the root cause fix well never happen. These things have been broken for a long time, and with out Michael Dexter driving this issue to get them fixed they would never even be addressed. If we apply his simple fixes we loose that pressure from him to have these fixes get in the tree.

@ed can we get this added to the CI work load as a once a week type run? IIRC it takes a 16 core machine about 3 days to run build_option_survey.sh

In D17040#364634, @rgrimes wrote:

@ed can we get this added to the CI work load as a once a week type run? IIRC it takes a 16 core machine about 3 days to run build_option_survey.sh

This was intended for @emaste, right?

This is partially obsoleted by https://reviews.freebsd.org/D19418

Great work bz@!