Page MenuHomeFreeBSD
Differential D14323

Use standard pattern for stdargs
ClosedPublic
Actions

Authored by imp on Feb 11 2018, 5:26 PM.
Tags
None
Referenced Files
F105911480: D14323.diff
Sun, Dec 22, 12:48 PM
Unknown Object (File)
Thu, Nov 28, 12:03 PM
Unknown Object (File)
Thu, Nov 28, 12:03 PM
Unknown Object (File)
Nov 15 2024, 6:39 PM
Unknown Object (File)
Oct 23 2024, 6:43 PM
Unknown Object (File)
Oct 18 2024, 4:12 AM
Unknown Object (File)
Oct 18 2024, 3:02 AM
Unknown Object (File)
Sep 29 2024, 8:10 PM
View All 86 Files
Subscribers
jhibbits
kan

Details

Reviewers
rwatson
jhb
brooks
arichardson
jmallett
adrian
emaste
nwhitehorn
jhibbits
marius
kan
Commits
rS329164: We don't support gcc < 4.2.1, so varargs.h now is just #error
rS329163: Use standard pattern for stdargs.h
Summary

mips stdargs.h has all kinds of junk for really old compilers. gcc 3 was released in 2001, so we don't need support for pre-gcc3 anymore. When you remove it, there's nothing left except for code that's a poorer version of sys/_stdarg.h. Migrate to that. In fact, sparc64 and powerpc could use the same.

Test Plan

I'm just doing a buildworld :) worked for mipsel, mips64, powerpc64, sparc64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Feb 11 2018, 5:26 PM
imp edited the summary of this revision. (Show Details)Feb 11 2018, 5:30 PM
imp edited the test plan for this revision. (Show Details)
imp added reviewers: rwatson, jhb, brooks, arichardson, jmallett, adrian, emaste.
imp added a comment.Feb 11 2018, 6:08 PM

I'll note that phk suggests that mips can't use this file in his initial commit, but I see no reason why it can't.

imp added a comment.Feb 11 2018, 6:09 PM

buildworld mips64 and mipsel completes w/o error

imp updated this revision to Diff 39193.Feb 11 2018, 10:22 PM
imp edited the summary of this revision. (Show Details)

sparc and powerpc too

Herald added a subscriber: jhibbits. · View Herald TranscriptFeb 11 2018, 10:22 PM
imp retitled this revision from Use standard pattern for varargs to Use standard pattern for stdargs.Feb 11 2018, 10:24 PM
imp edited the summary of this revision. (Show Details)
imp edited the test plan for this revision. (Show Details)
imp added reviewers: nwhitehorn, jhibbits, marius.
arichardson mentioned this in D14248: Make sys/mips/include/stdarg.h compatible with clang's builtin headers.Feb 11 2018, 10:33 PM
imp updated this revision to Diff 39195.Feb 11 2018, 10:35 PM
imp edited the summary of this revision. (Show Details)
  • We don't support gcc < 4.2.1, so varargs.h now is just #error
kan accepted this revision.Feb 12 2018, 3:10 AM
kan added a subscriber: kan.

no objection

This revision is now accepted and ready to land.Feb 12 2018, 3:10 AM
jhibbits accepted this revision.Feb 12 2018, 3:41 AM

If it builds, ship it.

Closed by commit rS329163: Use standard pattern for stdargs.h (authored by imp). · Explain WhyFeb 12 2018, 2:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
mips/
include/
165 lines
powerpc/
include/
147 lines
riscv/
include/
56 lines
sparc64/
include/
78 lines

Diff 39206

View Options

head/sys/mips/include/stdarg.h

Loading...
View Options

head/sys/powerpc/include/stdarg.h

Loading...
View Options

head/sys/riscv/include/stdarg.h

Loading...
View Options

head/sys/sparc64/include/stdarg.h

Loading...