Page MenuHomeFreeBSD

Use standard pattern for stdargs
ClosedPublic

Authored by imp on Feb 11 2018, 5:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 6, 12:58 AM
Unknown Object (File)
Wed, Mar 6, 12:58 AM
Unknown Object (File)
Jan 3 2024, 3:19 PM
Unknown Object (File)
Dec 31 2023, 4:40 AM
Unknown Object (File)
Dec 23 2023, 10:46 AM
Unknown Object (File)
Nov 26 2023, 1:34 PM
Unknown Object (File)
Nov 26 2023, 1:34 PM
Unknown Object (File)
Nov 13 2023, 1:32 PM
Subscribers

Details

Summary

mips stdargs.h has all kinds of junk for really old compilers. gcc 3 was released in 2001, so we don't need support for pre-gcc3 anymore. When you remove it, there's nothing left except for code that's a poorer version of sys/_stdarg.h. Migrate to that. In fact, sparc64 and powerpc could use the same.

Test Plan

I'm just doing a buildworld :) worked for mipsel, mips64, powerpc64, sparc64

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14968
Build 15079: arc lint + arc unit

Event Timeline

imp edited the test plan for this revision. (Show Details)

I'll note that phk suggests that mips can't use this file in his initial commit, but I see no reason why it can't.

buildworld mips64 and mipsel completes w/o error

imp edited the summary of this revision. (Show Details)

sparc and powerpc too

imp retitled this revision from Use standard pattern for varargs to Use standard pattern for stdargs.Feb 11 2018, 10:24 PM
imp edited the summary of this revision. (Show Details)
imp edited the test plan for this revision. (Show Details)
imp added reviewers: nwhitehorn, jhibbits, marius.
imp edited the summary of this revision. (Show Details)
  • We don't support gcc < 4.2.1, so varargs.h now is just #error
kan added a subscriber: kan.

no objection

This revision is now accepted and ready to land.Feb 12 2018, 3:10 AM
This revision was automatically updated to reflect the committed changes.