Details

Reviewers

kmacy
gallatin
scottl
shurd

Group Reviewers

Intel Networking

Summary

Latest updates can be found here: https://github.com/intel-wired-ethernet/freebsd/tree/ixl-iflib

SR-IOV and the VF driver neither work nor compile
netmap is untested
VLANs do not work
no iWARP support
no nvmupdate support

Other bugs:

Memory leaks when passing traffic
Poor UDP throughput when using larger-than-mtu message sizes in netperf (e.g. -m > 1472 w/ 1500 mtu)
Occasional watchdog messages and/or MDD events
TX descriptor writeback mode causes interface watchdog/resets during UDP_STREAM netperf

Test Plan

Full regression, but details to be filled in later.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7502
Build 7662: arc lint + arc unit

Event Timeline

kmacy updated this revision to Diff 13084.Feb 6 2016, 2:45 AM

kmacy retitled this revision from to convert ixl to iflib.

kmacy updated this object.

kmacy edited the test plan for this revision. (Show Details)

kmacy added reviewers: sbruno, gallatin.

kmacy set the repository for this revision to rS FreeBSD src repository - subversion.

kmacy added subscribers: scottl, benno.

Herald added a reviewer: Intel Networking. · View Herald TranscriptFeb 6 2016, 2:45 AM

Herald added a subscriber: imp. · View Herald Transcript

kmacy added a parent revision: D5211: import iflib.Feb 6 2016, 2:45 AM

Update to remove packet parsing from driver

This doesn't cleanly apply on top of 11-current, on rS295683.

In D5214#113348, @erj wrote:

This doesn't cleanly apply on top of 11-current, on rS295683.

I'll post an update tomorrow. Thanks.

Update to build against latest HEAD + GENERIC
@erj please try along with latest iflib patch

Some files in ixl in the newest diff still won't apply cleanly.

fix interrupt assignment, LUT setup, and flowid assignment per Gallatin
don't ignore whitespace in case it's causing patch application problems for @erj

In D5214#113808, @erj wrote:

Some files in ixl in the newest diff still won't apply cleanly.

@erj I _just_ cloned https://github.com/freebsd/freebsd.git 10 minutes ago and the latest patch applies cleanly against it

kmacy@serenity [~/devel/HEAD-iflib-merge|22:15|11] git diff -U9999 master sys/dev/ixl sys/modules/ixl sys/modules/ixlv > ~/ixl.diff

kmacy@serenity [~/devel|22:11|93] git clone https://github.com/freebsd/freebsd.git FreeBSD-HEAD
...
kmacy@serenity [~/devel|22:17|94] cd FreeBSD-HEAD
kmacy@serenity [~/devel/FreeBSD-HEAD|22:18|95] patch -p1 < ~/ixl.diff
Hmm... Looks like a unified diff to me...
...

kmacy@serenity [~/devel/FreeBSD-HEAD|22:18|97] find sys -name "*.rej" | wc

0       0       0

Yep! I can confirm it does.

In D5214#113827, @erj wrote:

Yep! I can confirm it does.

Great.

My most recent changes may well have caused regressions so for the moment YMWV. Drew is at least testing the converted ixl in -STABLE.

erj mentioned this in D5211: import iflib.Feb 19 2016, 12:47 AM

update against HEAD

Update for iflib interface update
Update TSO handling

Is this the final version? Or should there be a further update to this review?

Split in to legacy and iflib versions

kmacy added inline comments.May 13 2016, 5:32 AM

sys/dev/ixl/legacy_if_ixl.c
51 ↗	(On Diff #16242)	Version string is here guys!

I can attempt to update the iflib version of ixl with what he have internally, but would it be a better idea to base it off what's in the iflib version of ixgbe right now (D5213)?

erj mentioned this in D9227: ixl(4): Update to 1.7.12-k.Jan 18 2017, 1:20 AM

erj commandeered this revision.Feb 15 2017, 10:52 PM

erj added a reviewer: kmacy.

Convert ixl-1.6.6-k (or at least the PF-non-IOV driver) to iflib

Herald added a subscriber: ae. · View Herald TranscriptFeb 15 2017, 10:53 PM

erj added a parent revision: D5213: convert ixgbe to iflib.Feb 15 2017, 10:54 PM

ixl: Get rid of files accidentally re-added during rebase.

Remove old D5213 files.

ixl: Fix compile error

Add NOINTEL config file for testing
iflib: Update with style(9) fixes.
ixl(4): Begin process of converting ixl(4) to use iflib.
ixl: Copy over final bits of D5214 diff, possibly break some stuff.
ixl: Add more files.
ixl(4): Fix a lot of compile errors
ixl: ixl pf driver seems to compile ok now
Mostly compiles; start to remove legacy code...
ixl(4): Driver is iflib-only; compiles but causes kernel panic at attach.
ixl(4): PF driver compiles and ping works.
ixl(4): Remove comments; make queue interrupts RX-caused only
ixl(4): Edit comments
ixl: Get rid of files accidentally re-added during rebase.
ixl: Fix compile error
ixlv: Start converting driver
ixl: Update to 1.7.12; fix compile.
ixl: Change name to 700 series from just 7
ixlv: Convert more of driver
ixlv: VF driver still not fully converted, but now compiling
ixl: Bug fixes; label formatting in iflib
ixl: Fix bug where tx would stop working after ifconfig down && up
ixl: Random changes
ixl: Somehow fixed weird TXQ 0 bug supposedly fixed a couple commits ago
ixl: Change TODO comment from question to must-do
ixl: Start changes to support HW TX interrupts in iflib (like in legacy driver)
ixl: Fixes to get ixl building again, after iflib update.
ixl: Remove various comments and printfs
ixl: Updates.
ixl: Update reset handling; make some iflib functions non-static.

Harbormaster completed remote builds in B8941: Diff 27798.Apr 27 2017, 11:25 PM

Remove ixgbe updates.

Harbormaster completed remote builds in B8942: Diff 27799.Apr 27 2017, 11:27 PM

erj planned changes to this revision.Jul 24 2017, 5:25 PM

I'm working on this on a github branch here:

https://github.com/intel-wired-ethernet/freebsd/tree/iflib

It might be easier to follow along using that instead of updating this phabricator review. I think I'll return to this when it's more fully-baked.

Update converted version of ixl(4) to 1.9.8-k; includes some other bugfixes and updates.

Harbormaster completed remote builds in B16183: Diff 41560.Apr 17 2018, 12:32 AM

erj edited the summary of this revision. (Show Details)Apr 17 2018, 12:33 AM

erj edited the summary of this revision. (Show Details)

Replaced by https://reviews.freebsd.org/D15577

Convert ixl(4)to use iflib
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25255

sys/amd64/conf/GENERIC

sys/conf/files.amd64

sys/dev/ixl/i40e_osdep.c

sys/dev/ixl/if_ixl.c

sys/dev/ixl/if_ixlv.c

sys/dev/ixl/iflib_ixlv.h

sys/dev/ixl/iflib_ixlvc.c

sys/dev/ixl/ixl.h

sys/dev/ixl/ixl_debug.h

sys/dev/ixl/ixl_pf.h

sys/dev/ixl/ixl_pf_iov.c

sys/dev/ixl/ixl_pf_main.c

sys/dev/ixl/ixl_txrx.c

sys/dev/ixl/ixlv.h

sys/dev/ixl/ixlvc.c

sys/modules/Makefile

sys/modules/ixl/Makefile

sys/modules/ixlv/Makefile

sys/net/iflib.c

Convert ixl(4)to use iflibAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25255

sys/amd64/conf/GENERIC

sys/conf/files.amd64

sys/dev/ixl/i40e_osdep.c

sys/dev/ixl/if_ixl.c

sys/dev/ixl/if_ixlv.c

sys/dev/ixl/iflib_ixlv.h

sys/dev/ixl/iflib_ixlvc.c

sys/dev/ixl/ixl.h

sys/dev/ixl/ixl_debug.h

sys/dev/ixl/ixl_pf.h

sys/dev/ixl/ixl_pf_iov.c

sys/dev/ixl/ixl_pf_main.c

sys/dev/ixl/ixl_txrx.c

sys/dev/ixl/ixlv.h

sys/dev/ixl/ixlvc.c

sys/modules/Makefile

sys/modules/ixl/Makefile

sys/modules/ixlv/Makefile

sys/net/iflib.c

Convert ixl(4)to use iflib
AbandonedPublic
Actions

Revision Contents
Changeset List