Page MenuHomeFreeBSD

ixl(4): Update to 1.7.12-k
ClosedPublic

Authored by erj on Jan 18 2017, 1:19 AM.

Details

Summary

Refresh upstream driver before impending conversion to iflib. This should be replaced by an iflib-converted version in a few weeks (in D5214), with this version eventually getting MFC'd into stable/10.

Major new features:

  • Support for Fortville-based 25G adapters
  • Support for I2C reads/writes

(One note on the I2C functionality: Fortville currently doesn't support any way for software to synchronize accesses to the I2C bus with the firmware. So, to prevent getting or sending corrupt data, you should set dev.ixl.0.debug.disable_fw_link_management=1 when using I2C [this will disable link!], then set it to 0 when done. The driver implements the SIOCGI2C ioctl, so ifconfig -v works for reading I2C data, but there are read_i2c and write_i2c sysctls under the debug tree [the latter being useful for upper page support in QSFP+]).

  • Addition of an iWARP client interface (so the future iWARP driver for X722 devices can communicate with the base driver)
    • Compiling this option in is enabled by default, with "options IXL_IW" in GENERIC. I'm open to just stripping out the define and leaving the interface as always enabled, if adding that is too much.
Test Plan

I've tried compiling this with and without IXL_IW on amd64 with no errors.

Functional touch testing (on this patch) to be done by Jeff's team.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6862
Build 7064: arc lint + arc unit

Event Timeline

erj updated this revision to Diff 24141.Jan 18 2017, 1:19 AM
erj retitled this revision from to ixl(4): Update to 1.7.12-k.
erj updated this object.
erj edited the test plan for this revision. (Show Details)
erj added a reviewer: Intel Networking.
erj set the repository for this revision to rS FreeBSD src repository.
erj updated this object.Jan 18 2017, 1:20 AM
erj edited edge metadata.
erj updated this object.
erj updated this object.
jeffrey.e.pieper_intel.com edited the test plan for this revision. (Show Details)Jan 18 2017, 2:05 AM
sbruno added a subscriber: sbruno.Jan 18 2017, 2:29 PM
sbruno added inline comments.
sys/modules/ixlv/Makefile
5–6

Is pci_iov_if.h no longer needed?

erj added inline comments.Jan 18 2017, 5:12 PM
sys/modules/ixlv/Makefile
5–6

The VF driver never actually needed any PCI_IOV stuff. But actually the makefile is missing opt_ixl.h, so it won't build as a module. I'm about to fix that.

erj updated this revision to Diff 24163.EditedJan 18 2017, 5:29 PM
erj updated this object.

ixl(4) changes

  • Add opt_ixl.h to ixlv Makefile for build
  • Add comment describing IXL_IW to GENERIC config
  • Default to disabling the iWARP client interface by setting tunable to 0
sbruno accepted this revision.Jan 18 2017, 5:36 PM
sbruno added a reviewer: sbruno.

stlgtm

Commit it and lets see what else we can break today.

This revision is now accepted and ready to land.Jan 18 2017, 5:36 PM
erj added a comment.Jan 18 2017, 9:31 PM

I'm going to wait for Jeff's team to give the okay before I commit it. I don't want to break more than I have to. :v

erj closed this revision.Feb 16 2017, 12:24 AM

Committed in rS313497.