Page MenuHomeFreeBSD

iflib fixes
ClosedPublic

Authored by kmacy on Nov 18 2016, 12:31 AM.

Details

Summary
  • reset gen on down
  • initialize admin task statically
  • drain mp_ring on down
  • don't drop context lock on stop
  • reset error stats on down
  • fix typo in min_latency sysctl
  • return ENOBUFS from if_transmit if the driver isn't running or the link is down

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kmacy updated this revision to Diff 22303.Nov 18 2016, 12:31 AM
kmacy retitled this revision from to iflib fixes.
kmacy updated this object.
kmacy edited the test plan for this revision. (Show Details)
kmacy added a reviewer: sbruno.
kmacy set the repository for this revision to rS FreeBSD src repository.
shurd accepted this revision.Nov 18 2016, 12:55 AM
shurd edited edge metadata.

Tested with if_bnxt, looks good.

This revision is now accepted and ready to land.Nov 18 2016, 12:55 AM
kmacy updated this revision to Diff 22304.Nov 18 2016, 12:58 AM
kmacy edited edge metadata.

fix derp

This revision now requires review to proceed.Nov 18 2016, 12:58 AM
shurd accepted this revision.Nov 18 2016, 12:59 AM
shurd edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2016, 12:59 AM
sbruno accepted this revision.Nov 18 2016, 3:49 AM
sbruno edited edge metadata.

Tested with ixgbe(4) and its iflib update review D5213, looks goodly. Will commit shortly.

This revision was automatically updated to reflect the committed changes.