hwpmc: add the LBR allocation policy
Needs ReviewPublic
Actions

Authored by afscoelho_gmail.com on Sat, Oct 10, 1:22 AM.

Tags

None

Referenced Files

	F175846287: D60568.id.diff
	Tue, Oct 13, 8:36 PM

	F175835829: D60568.diff
	Tue, Oct 13, 6:31 PM

	F175740728: D60568.diff
	Mon, Oct 12, 10:55 PM

	Unknown Object (File)
	Mon, Oct 12, 12:13 AM

	Unknown Object (File)
	Sun, Oct 11, 11:53 AM

	Unknown Object (File)
	Sun, Oct 11, 6:20 AM

	Unknown Object (File)
	Sun, Oct 11, 1:18 AM

	Unknown Object (File)
	Sat, Oct 10, 8:22 PM

View All 14 Files

Subscribers

imp

Details

Reviewers

mhorne
gnn
ali_mashtizadeh.com

Group Reviewers

pmc

Summary

Kernel branch records leak kernel addresses. If an LBR PMC can record
kernel branches, require PRIV_PMC_SYSTEM and refuse it in a jail.
User-only LBR keeps the normal rules.

LBR samples need a log file, so require one.

Depends on D60567

Test Plan

Built amd64 GENERIC + hwpmc.ko, GENERIC without HWPMC_HOOKS, and arm64.
Ran tests/sys/pmc on AMD Zen 6 (LBR v2).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77941
Build 74824: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Sat, Oct 10, 1:22 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Oct 10, 1:22 AM

afscoelho_gmail.com requested review of this revision.Sat, Oct 10, 1:22 AM

Harbormaster completed remote builds in B77941: Diff 189323.Sat, Oct 10, 1:22 AM

afscoelho_gmail.com added a child revision: D60569: hwpmc/amd: add LBR v2 detection and filter reservation.Sat, Oct 10, 1:22 AM

Rebase on the updated D60567. No code changes.

Harbormaster completed remote builds in B78143: Diff 189785.Tue, Oct 13, 7:57 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_mod.c

50 lines

Diff 189323

View Options

hwpmc: add the LBR allocation policyNeeds ReviewPublicActions