Page MenuHomeFreeBSD
Differential D46717

diff: support -qq to output absolutely nothing
Needs ReviewPublic
Actions

Authored by allanjude on Sep 20 2024, 3:31 PM.
Tags
None
Referenced Files
F174949304: D46717.id188889.diff
Wed, Oct 7, 3:44 AM
F174923434: D46717.id188889.diff
Wed, Oct 7, 12:15 AM
F174923272: D46717.id143542.diff
Wed, Oct 7, 12:13 AM
F174922880: D46717.diff
Wed, Oct 7, 12:10 AM
Unknown Object (File)
Thu, Oct 1, 7:51 PM
Unknown Object (File)
Thu, Sep 24, 4:40 AM
Unknown Object (File)
Mon, Sep 14, 2:46 PM
Unknown Object (File)
Sun, Sep 13, 12:23 PM
View All 97 Files
Subscribers
imp
michaelo

Details

Reviewers
markj
gordon
kevans
Group Reviewers
Klara
Summary

diff: support -qq to output absolutely nothing

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77775
Build 74658: arc lint + arc unit

Event Timeline

allanjude created this revision.Sep 20 2024, 3:31 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 20 2024, 3:31 PM
allanjude requested review of this revision.Sep 20 2024, 3:31 PM
Harbormaster completed remote builds in B59540: Diff 143542.Sep 20 2024, 3:31 PM
allanjude added a comment.Sep 20 2024, 3:31 PM

still a WIP

markj added inline comments.Sep 21 2024, 1:24 PM
usr.bin/diff/diff.c
282

This way, if one writes -qqq, it'll flip back to D_BRIEF. I guess that's not intentional?

usr.bin/diff/diff.h
53
allanjude updated this revision to Diff 188889.Tue, Oct 6, 6:11 PM

Address markj's feedback

Harbormaster completed remote builds in B77775: Diff 188889.Tue, Oct 6, 6:11 PM
allanjude added reviewers: kevans, Klara.Tue, Oct 6, 6:11 PM
allanjude marked 2 inline comments as done.
allanjude mentioned this in D46716: periodic 100.chksetuid: supress output if diff is purely whitespace.Tue, Oct 6, 6:17 PM
michaelo added a subscriber: michaelo.Tue, Oct 6, 6:19 PM

PLease MFC this, it is trivial.

allanjude edited the summary of this revision. (Show Details)Tue, Oct 6, 6:43 PM
allanjude edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
1 line
13 lines
7 lines

Diff 188889

View Options

usr.bin/diff/diff.h

Loading...
View Options

usr.bin/diff/diff.c

Loading...
View Options

usr.bin/diff/diffreg.c

Loading...