Paths

Table of Contentst

Differential D59169

dev: acpica: Add PCI device methods for aarch64
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Aug 25 2026, 12:49 PM.

Tags

None

Referenced Files

	F173222890: D59169.id186955.diff
	Thu, Sep 24, 10:47 AM

	F173201819: D59169.id186204.diff
	Thu, Sep 24, 6:40 AM

	F173201468: D59169.id186205.diff
	Thu, Sep 24, 6:37 AM

	F173195584: D59169.id186955.diff
	Thu, Sep 24, 5:47 AM

	F173186461: D59169.id186365.diff
	Thu, Sep 24, 4:26 AM

	Unknown Object (File)
	Wed, Sep 23, 5:20 AM

	Unknown Object (File)
	Wed, Sep 23, 12:18 AM

	Unknown Object (File)
	Tue, Sep 22, 11:42 AM

View All 95 Files

Subscribers

Details

Reviewers

andrew
manu
jhb
markj

Commits

rG9f24c7d54222: dev: acpica: Add PCI device methods for aarch64

Summary

Add pci_get_id() and pci_alloc_msi() device methods for aarch64 platforms.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76740
Build 73623: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Aug 25 2026, 12:49 PM

Herald added a reviewer: andrew. · View Herald TranscriptAug 25 2026, 12:49 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

sarah.walker2_arm.com requested review of this revision.Aug 25 2026, 12:49 PM

Harbormaster completed remote builds in B76142: Diff 185022.Aug 25 2026, 12:49 PM

sarah.walker2_arm.com added a parent revision: D59168: sys: arm64: acpica: Add support for GICv5 ITS & IWB nodes.Aug 25 2026, 12:49 PM

sarah.walker2_arm.com added a child revision: D59170: arm64: Add GICv5 GSI definitions.

andrew mentioned this in D59168: sys: arm64: acpica: Add support for GICv5 ITS & IWB nodes.Tue, Sep 8, 9:35 AM

andrew added reviewers: jhb, markj.

Add missing prototypes

Harbormaster completed remote builds in B76662: Diff 186204.Tue, Sep 8, 11:20 AM

Remove now-superfluous prototypes

Harbormaster completed remote builds in B76663: Diff 186205.Tue, Sep 8, 11:21 AM

Seems fine to me. Rather than defining the methods only on arm64, can we instead only conditionalize the acpi_iort_* calls? Or is there some specific reason not to handle it that way?

sys/arm64/acpica/acpi_iort.c
842	Extra newline

In D59169#1365873, @markj wrote:

Seems fine to me. Rather than defining the methods only on arm64, can we instead only conditionalize the acpi_iort_* calls? Or is there some specific reason not to handle it that way?

No, I can't think of a reason not to do that.

Move aarch64 conditionals

Harbormaster completed remote builds in B76692: Diff 186256.Wed, Sep 9, 10:29 AM

Looks ok, my comments are just style nits.

sys/arm64/acpica/acpi_iort.c
803	"_alloc_msi" would be more consistent with existing interfaces.
sys/dev/acpica/acpi.c
2354	Explicit comparison with 0 would be better style and clearer IMO.

This revision is now accepted and ready to land.Wed, Sep 9, 12:27 PM

Address style feedback

This revision now requires review to proceed.Wed, Sep 9, 1:16 PM

Harbormaster completed remote builds in B76693: Diff 186258.Wed, Sep 9, 1:16 PM

markj added inline comments.Thu, Sep 10, 7:53 AM

sys/arm64/acpica/acpi_iort.c
842	Still here.
sys/dev/acpica/acpi.c
2368	Same comment here about comparison with 0.

Address review comments

Harbormaster completed remote builds in B76733: Diff 186347.Thu, Sep 10, 8:44 AM

markj accepted this revision.Thu, Sep 10, 9:09 AM

This revision is now accepted and ready to land.Thu, Sep 10, 9:09 AM

andrew added inline comments.Thu, Sep 10, 10:29 AM

sys/dev/acpica/acpi.c
161	Is this still needed (and around `DEVMETHOD` below)? It looks like it would break the build on non-arm64 as the functions will be unused.

Remove unnecessary aarch64 guards

This revision now requires review to proceed.Thu, Sep 10, 10:52 AM

Harbormaster completed remote builds in B76740: Diff 186365.Thu, Sep 10, 10:52 AM

andrew accepted this revision.Thu, Sep 10, 11:20 AM

This revision is now accepted and ready to land.Thu, Sep 10, 11:20 AM

Closed by commit rG9f24c7d54222: dev: acpica: Add PCI device methods for aarch64 (authored by sarah.walker2_arm.com, committed by andrew). · Explain WhyThu, Sep 17, 9:56 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG9f24c7d54222: dev: acpica: Add PCI device methods for aarch64.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

acpica/

60 lines

dev/

acpica/

39 lines

2 lines

Diff 186365

sys/arm64/acpica/acpi_iort.c

Loading...

sys/dev/acpica/acpi.c

Loading...

sys/dev/acpica/acpivar.h

Loading...