Page MenuHomeFreeBSD
Differential D59169

dev: acpica: Add PCI device methods for aarch64
Needs ReviewPublic
Actions

Authored by sarah.walker2_arm.com on Tue, Aug 25, 12:49 PM.
Tags
None
Referenced Files
F171183884: D59169.id.diff
Wed, Sep 9, 8:15 AM
Unknown Object (File)
Tue, Sep 8, 1:30 PM
Unknown Object (File)
Tue, Sep 8, 12:51 PM
Unknown Object (File)
Mon, Sep 7, 2:05 PM
Unknown Object (File)
Sat, Sep 5, 9:58 AM
Unknown Object (File)
Sat, Sep 5, 9:21 AM
Unknown Object (File)
Sat, Sep 5, 3:30 AM
Unknown Object (File)
Fri, Sep 4, 11:44 PM
View All 35 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
jhb
markj
Summary

Add pci_get_id() and pci_alloc_msi() device methods for aarch64 platforms.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76663
Build 73546: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Tue, Aug 25, 12:49 PM
Herald added a reviewer: andrew. · View Herald TranscriptTue, Aug 25, 12:49 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
sarah.walker2_arm.com requested review of this revision.Tue, Aug 25, 12:49 PM
Harbormaster completed remote builds in B76142: Diff 185022.Tue, Aug 25, 12:49 PM
sarah.walker2_arm.com added a parent revision: D59168: sys: arm64: acpica: Add support for GICv5 ITS & IWB nodes.Tue, Aug 25, 12:49 PM
sarah.walker2_arm.com added a child revision: D59170: arm64: Add GICv5 GSI definitions.
andrew mentioned this in D59168: sys: arm64: acpica: Add support for GICv5 ITS & IWB nodes.Tue, Sep 8, 9:35 AM
andrew added reviewers: jhb, markj.
sarah.walker2_arm.com updated this revision to Diff 186204.Tue, Sep 8, 11:20 AM

Add missing prototypes

Harbormaster completed remote builds in B76662: Diff 186204.Tue, Sep 8, 11:20 AM
sarah.walker2_arm.com updated this revision to Diff 186205.Tue, Sep 8, 11:21 AM

Remove now-superfluous prototypes

Harbormaster completed remote builds in B76663: Diff 186205.Tue, Sep 8, 11:21 AM
markj added a comment.Wed, Sep 9, 9:50 AM

Seems fine to me. Rather than defining the methods only on arm64, can we instead only conditionalize the acpi_iort_* calls? Or is there some specific reason not to handle it that way?

sys/arm64/acpica/acpi_iort.c
842

Extra newline

sarah.walker2_arm.com added a comment.Wed, Sep 9, 10:21 AM
In D59169#1365873, @markj wrote:

Seems fine to me. Rather than defining the methods only on arm64, can we instead only conditionalize the acpi_iort_* calls? Or is there some specific reason not to handle it that way?

No, I can't think of a reason not to do that.

sarah.walker2_arm.com updated this revision to Diff 186256.Wed, Sep 9, 10:29 AM

Move aarch64 conditionals

Harbormaster completed remote builds in B76692: Diff 186256.Wed, Sep 9, 10:29 AM
markj accepted this revision.Wed, Sep 9, 12:27 PM

Looks ok, my comments are just style nits.

sys/arm64/acpica/acpi_iort.c
803

"_alloc_msi" would be more consistent with existing interfaces.

sys/dev/acpica/acpi.c
2358

Explicit comparison with 0 would be better style and clearer IMO.

This revision is now accepted and ready to land.Wed, Sep 9, 12:27 PM
sarah.walker2_arm.com updated this revision to Diff 186258.Wed, Sep 9, 1:16 PM

Address style feedback

This revision now requires review to proceed.Wed, Sep 9, 1:16 PM
Harbormaster completed remote builds in B76693: Diff 186258.Wed, Sep 9, 1:16 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
acpica/
61 lines
dev/
acpica/
41 lines
2 lines

Diff 186205

View Options

sys/arm64/acpica/acpi_iort.c

Loading...
View Options

sys/dev/acpica/acpi.c

Loading...
View Options

sys/dev/acpica/acpivar.h

Loading...