Details

Reviewers

jlduran
jrm
ashish
imp

Summary

Introduce gpt.sh as the default GPT partitioned plan with dual BIOS and UEFI boot support, dynamic partition sizing and labeled root, altroot, cfg and data partitions.

Move legacy-only helpers and configuration variables (such as NANO_MD_BACKING, NANO_IMAGE_MBRONLY, FlashDevice, UsbDevice, and legacy slice population helpers) from defaults.sh into legacy.sh.

Bump the default NANO_RAM_TMPVARSIZE since pkgbase requires significantly more space in /var/db/pkg. Leave the legacy plan default unchanged.

Move change_password, save_cfg and save_sshkeys from root/bin to usr/local/sbin under defaults/Files, which is on the default PATH.

Set NANO_DRIVE from NANO_LABEL instead of hard coding vtbd0, and clean up tgt_dir2symlink() and make_boot_partition().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76127
Build 73010: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:21 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:21 AM

senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:21 AM

Harbormaster completed remote builds in B75717: Diff 184329.Wed, Aug 19, 10:21 AM

senguptaangshuman17_gmail.com added a parent revision: D58963: nanobsd: Disable dumpdev.Wed, Aug 19, 10:21 AM

senguptaangshuman17_gmail.com added a child revision: D58965: nanobsd: Rename NANO_PLAN gpt -> default, bump NANO_RAM_TMPVARSIZE.

jlduran mentioned this in D58981: nanobsd: Allow custom alignment boundaries.Wed, Aug 19, 4:36 PM

jlduran added inline comments.Wed, Aug 19, 4:39 PM

tools/tools/nanobsd/FlashDevice.sub
39 ↗	(On Diff #184329)	Please submit all non-functional, style(9)-related changes in a single revision (D58931).
tools/tools/nanobsd/defaults.sh
1579	This function gets replaced by `strtobytes()` in D58969. Please unify, and introduce in a separate commit, as this is a legacy-breaking change.

senguptaangshuman17_gmail.com updated this revision to Diff 184464.Thu, Aug 20, 10:11 AM

Harbormaster completed remote builds in B75798: Diff 184464.Thu, Aug 20, 10:11 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184515.Thu, Aug 20, 12:23 PM

Harbormaster completed remote builds in B75844: Diff 184515.Thu, Aug 20, 12:23 PM

Include NANO_ALIGN in initial calculate_partitioning implementation

Harbormaster completed remote builds in B75866: Diff 184540.Thu, Aug 20, 2:12 PM

Clean up recovery ESP and simplify make_esp_partition

Harbormaster completed remote builds in B75870: Diff 184545.Thu, Aug 20, 2:26 PM

senguptaangshuman17_gmail.com mentioned this in D58975: nanobsd: Remove all traces of a recovery ESP.Thu, Aug 20, 2:27 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184550.Thu, Aug 20, 2:29 PM

Harbormaster completed remote builds in B75875: Diff 184550.Thu, Aug 20, 2:29 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184561.Thu, Aug 20, 3:11 PM

Harbormaster completed remote builds in B75884: Diff 184561.Thu, Aug 20, 3:11 PM

senguptaangshuman17_gmail.com edited parent revisions, added: D58969: nanobsd: Change sizes to use bytes exclusively; removed: D58963: nanobsd: Disable dumpdev.Thu, Aug 20, 3:14 PM

Made the changes and rebased accordingly

senguptaangshuman17_gmail.com marked 2 inline comments as done.Thu, Aug 20, 3:34 PM

senguptaangshuman17_gmail.com added a reviewer: imp.Thu, Aug 20, 3:50 PM

jlduran added inline comments.Thu, Aug 20, 5:25 PM

tools/tools/nanobsd/gpt.sh
2	I think this file should be renamed to `ufs.sh`, when adding support for ZFS, this becomes evident. I can show you a draft of what I have for ZFS in our next meeting.

senguptaangshuman17_gmail.com added inline comments.Thu, Aug 20, 6:36 PM

tools/tools/nanobsd/gpt.sh
2	I think this file should be renamed to `ufs.sh`, when adding support for ZFS, this becomes evident. I can show you a draft of what I have for ZFS in our next meeting. Ok sure, so should I update the name of this file to ufs.sh?

Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 6:36 PM

Address review comments: normalize all 5 XXXJL comments to # XXX:

Harbormaster completed remote builds in B75915: Diff 184601.Thu, Aug 20, 7:03 PM

lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:17 PM

Clean up merge conflict markers in defaults.sh

Harbormaster completed remote builds in B75972: Diff 184754.Sat, Aug 22, 10:32 PM

jlduran mentioned this in D58976: nanobsd: Rename the gpt directory to defaults.Sun, Aug 23, 2:34 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184810.Sun, Aug 23, 8:22 PM

Harbormaster completed remote builds in B75997: Diff 184810.Sun, Aug 23, 8:22 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184839.Sun, Aug 23, 11:03 PM

Harbormaster completed remote builds in B76025: Diff 184839.Sun, Aug 23, 11:03 PM

jlduran mentioned this in D58982: nanobsd: Add an optional CIDATA partition.Mon, Aug 24, 1:24 PM

jlduran mentioned this in D58965: nanobsd: Rename NANO_PLAN gpt -> default, bump NANO_RAM_TMPVARSIZE.Mon, Aug 24, 1:27 PM

jlduran mentioned this in D58978: nanobsd: Handle the data partition in fstab.Mon, Aug 24, 2:33 PM

senguptaangshuman17_gmail.com added a child revision: D58966: nanobsd: Put customizations in a separate file.Tue, Aug 25, 6:07 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184958.Tue, Aug 25, 6:10 AM

Harbormaster completed remote builds in B76081: Diff 184958.Tue, Aug 25, 6:10 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76127: Diff 185004.Tue, Aug 25, 8:00 AM

senguptaangshuman17_gmail.com updated this revision to Diff 185108.Tue, Aug 25, 9:01 PM

Harbormaster completed remote builds in B76167: Diff 185108.Tue, Aug 25, 9:01 PM

Please see: https://github.com/Coderangshu/freebsd-src/pull/60, which contains a WIP of NanoBSD using ZFS (the ZFS part is not really relevant at the moment, it was just an experiment). It illustrates that the file gpt.sh should actually be named ufs.sh and that common functions inherent to a GPT partitioning scheme belong in defaults.sh, leaving filesystem-specific functions inside their respective files (ufs.sh, zfs.sh, cd9660.sh, msdos.sh, i.e., anything that makefs(8) supports).

senguptaangshuman17_gmail.com edited the summary of this revision. (Show Details)Thu, Aug 27, 9:31 PM

Update makefs options with -DxZ and metalog existence check

Harbormaster completed remote builds in B76258: Diff 185268.Thu, Aug 27, 9:35 PM

nanobsd: Add gpt support
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 185004

tools/tools/nanobsd/Files/root/change_password

tools/tools/nanobsd/Files/root/update

tools/tools/nanobsd/Files/root/updatep1

tools/tools/nanobsd/Files/root/updatep2

tools/tools/nanobsd/defaults.sh

tools/tools/nanobsd/defaults/Files.mtree

tools/tools/nanobsd/defaults/Files/usr/local/sbin/change_password

tools/tools/nanobsd/defaults/Files/usr/local/sbin/save_cfg

tools/tools/nanobsd/defaults/Files/usr/local/sbin/save_sshkeys

tools/tools/nanobsd/defaults/Files/usr/local/sbin/update

tools/tools/nanobsd/gpt.sh

tools/tools/nanobsd/legacy.sh

tools/tools/nanobsd/nanobsd.sh

nanobsd: Add gpt supportNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 185004

tools/tools/nanobsd/Files/root/change_password

tools/tools/nanobsd/Files/root/update

tools/tools/nanobsd/Files/root/updatep1

tools/tools/nanobsd/Files/root/updatep2

tools/tools/nanobsd/defaults.sh

tools/tools/nanobsd/defaults/Files.mtree

tools/tools/nanobsd/defaults/Files/usr/local/sbin/change_password

tools/tools/nanobsd/defaults/Files/usr/local/sbin/save_cfg

tools/tools/nanobsd/defaults/Files/usr/local/sbin/save_sshkeys

tools/tools/nanobsd/defaults/Files/usr/local/sbin/update

tools/tools/nanobsd/gpt.sh

tools/tools/nanobsd/legacy.sh

tools/tools/nanobsd/nanobsd.sh

nanobsd: Add gpt support
Needs ReviewPublic
Actions

Revision Contents
Changeset List