Page MenuHomeFreeBSD
Differential D58964

nanobsd: Add gpt support
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:21 AM.
Tags
None
Referenced Files
F167403253: D58964.id184464.diff
Fri, Aug 21, 2:01 PM
F167402822: D58964.id184601.diff
Fri, Aug 21, 1:57 PM
F167402142: D58964.id184515.diff
Fri, Aug 21, 1:52 PM
F167402048: D58964.id184329.diff
Fri, Aug 21, 1:51 PM
F167402043: D58964.id184540.diff
Fri, Aug 21, 1:51 PM
F167402019: D58964.id184545.diff
Fri, Aug 21, 1:51 PM
F167401747: D58964.id184561.diff
Fri, Aug 21, 1:49 PM
F167401321: D58964.id184550.diff
Fri, Aug 21, 1:44 PM
View All 9 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
imp
Summary

Introduce gpt.sh, a GPT partitioned plan with dual BIOS and UEFI
boot support, dynamic partition sizing and labeled root, altroot,
cfg and data partitions. Move legacy only pieces from defaults.sh
into legacy.sh.

Move change_password, save_cfg and save_sshkeys from root/bin to
usr/local/sbin, which is on the default PATH.

Set NANO_DRIVE from NANO_LABEL instead of hard coding vtbd0, and
clean up tgt_dir2symlink() and make_boot_partition().

Co-authored-by: Jose Luis Duran <jlduran@FreeBSD.org>
Sponsored by: Google LLC (GSoC 2026)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75875
Build 72758: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:21 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:21 AM
Harbormaster completed remote builds in B75717: Diff 184329.Wed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com added a parent revision: D58963: nanobsd: Disable dumpdev.Wed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com added a child revision: D58965: nanobsd: Rename NANO_PLAN gpt -> default, bump NANO_RAM_TMPVARSIZE.
jlduran mentioned this in D58981: nanobsd: Allow custom alignment boundaries.Wed, Aug 19, 4:36 PM
jlduran added inline comments.Wed, Aug 19, 4:39 PM
tools/tools/nanobsd/FlashDevice.sub
39

Please submit all non-functional, style(9)-related changes in a single revision (D58931).

tools/tools/nanobsd/defaults.sh
1631

This function gets replaced by strtobytes() in D58969. Please unify, and introduce in a separate commit, as this is a legacy-breaking change.

senguptaangshuman17_gmail.com updated this revision to Diff 184464.Thu, Aug 20, 10:11 AM
Harbormaster completed remote builds in B75798: Diff 184464.Thu, Aug 20, 10:11 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184515.Thu, Aug 20, 12:23 PM
Harbormaster completed remote builds in B75844: Diff 184515.Thu, Aug 20, 12:23 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184540.Thu, Aug 20, 2:12 PM

Include NANO_ALIGN in initial calculate_partitioning implementation

Harbormaster completed remote builds in B75866: Diff 184540.Thu, Aug 20, 2:12 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184545.Thu, Aug 20, 2:26 PM

Clean up recovery ESP and simplify make_esp_partition

Harbormaster completed remote builds in B75870: Diff 184545.Thu, Aug 20, 2:26 PM
senguptaangshuman17_gmail.com mentioned this in D58975: nanobsd: Remove all traces of a recovery ESP.Thu, Aug 20, 2:27 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184550.Thu, Aug 20, 2:29 PM
Harbormaster completed remote builds in B75875: Diff 184550.Thu, Aug 20, 2:29 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184561.Thu, Aug 20, 3:11 PM
Harbormaster completed remote builds in B75884: Diff 184561.Thu, Aug 20, 3:11 PM
senguptaangshuman17_gmail.com edited parent revisions, added: D58969: nanobsd: Change sizes to use bytes exclusively; removed: D58963: nanobsd: Disable dumpdev.Thu, Aug 20, 3:14 PM
senguptaangshuman17_gmail.com added a comment.Thu, Aug 20, 3:32 PM

Made the changes and rebased accordingly

senguptaangshuman17_gmail.com marked 2 inline comments as done.Thu, Aug 20, 3:34 PM
senguptaangshuman17_gmail.com added a reviewer: imp.Thu, Aug 20, 3:50 PM
jlduran added inline comments.Thu, Aug 20, 5:25 PM
tools/tools/nanobsd/gpt.sh
2

I think this file should be renamed to ufs.sh, when adding support for ZFS, this becomes evident. I can show you a draft of what I have for ZFS in our next meeting.

senguptaangshuman17_gmail.com added inline comments.Thu, Aug 20, 6:36 PM
tools/tools/nanobsd/gpt.sh
2

I think this file should be renamed to ufs.sh, when adding support for ZFS, this becomes evident. I can show you a draft of what I have for ZFS in our next meeting.

Ok sure, so should I update the name of this file to ufs.sh?

Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 6:36 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184601.Thu, Aug 20, 7:03 PM

Address review comments: normalize all 5 XXXJL comments to # XXX:

Harbormaster completed remote builds in B75915: Diff 184601.Thu, Aug 20, 7:03 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:17 PM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
Files/
root/
6 lines
5 lines
18 lines
18 lines
13 lines
316 lines
embedded/
25 lines
470 lines
gpt/
10 lines
Files/
usr/
local/
sbin/
100 lines
25 lines
28 lines
gpt/
Files/
usr/
local/
sbin/
Files/
root/
6 lines
73 lines
17 lines

Diff 184550

View Options

tools/tools/nanobsd/Files/root/change_password

Loading...
View Options

tools/tools/nanobsd/Files/root/update

Loading...
View Options

tools/tools/nanobsd/Files/root/updatep1

Loading...
View Options

tools/tools/nanobsd/Files/root/updatep2

Loading...
View Options

tools/tools/nanobsd/FlashDevice.sub

Loading...
View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/embedded/common

Loading...
View Options

tools/tools/nanobsd/gpt.sh

Loading...
View Options

tools/tools/nanobsd/gpt/Files.mtree

Loading...
View Options

tools/tools/nanobsd/gpt/Files/usr/local/sbin/change_password

Loading...
View Options

tools/tools/nanobsd/gpt/Files/usr/local/sbin/save_cfg

Loading...
View Options

tools/tools/nanobsd/gpt/Files/usr/local/sbin/save_sshkeys

Loading...
View Options

tools/tools/nanobsd/gpt/Files/usr/local/sbin/update

Loading...
View Options

tools/tools/nanobsd/legacy.sh

Loading...
View Options

tools/tools/nanobsd/nanobsd.sh

Loading...