nanobsd: Normalize style in common functions

[senguptaangshuman17_gmail.com]

Summary

Prefer $(...) over backticks, drop the space before ";" in
conditionals, and normalize sentence-ending punctuation and line
wrapping in comments.

Use printf %s for metalog entries built from path variables so
backslash sequences in paths are printed verbatim.

Collapse the remaining split for loops onto one line to match the
style already used elsewhere in defaults.sh.

Replace sort | uniq with sort -u in setup_nanobsd() and cust_pkgng().

No functional change.

[imp]

tools/tools/nanobsd/defaults.sh

56

I'm no tat all sure that I like this style. Some sentences have a full stop (period) at the end while others do not. It seems needlessly churny for no good benefit.

188

Preferring $() is a great change.

273

But two spaces after a period is something I can get behind.

289

This always should have been printf.

322

I like moving the 'do' up too.

739

shouldn't we indent the cpio more than the find?

[senguptaangshuman17_gmail.com]

Include style cleanups for FlashDevice.sub

[senguptaangshuman17_gmail.com]

Include style cleanups for FlashDevice.sub

[senguptaangshuman17_gmail.com]

Address review comments: style normalization, FlashDevice.sub fixes, and comment cleanups

[senguptaangshuman17_gmail.com]

The full stack of commits can be found here coderangshu/freebsd-src

[jlduran]

In D58931#1356122, @senguptaangshuman17_gmail.com wrote:

The full stack of commits can be found here coderangshu/freebsd-src

Thank you! It is easier for me to track these changes directly from git.
I would remind consumers of this branch, that it gets interactively rebased on top of the main branch on a weekly basis.

[senguptaangshuman17_gmail.com]

Style and comment formatting fixups in defaults.sh