Page MenuHomeFreeBSD
Differential D58931

nanobsd: Normalize style in common functions
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Tue, Aug 18, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 13, 6:07 AM
Unknown Object (File)
Thu, Sep 10, 7:17 PM
Unknown Object (File)
Thu, Sep 10, 7:48 AM
Unknown Object (File)
Wed, Sep 9, 8:14 AM
Unknown Object (File)
Wed, Sep 9, 3:34 AM
Unknown Object (File)
Wed, Sep 9, 2:36 AM
Unknown Object (File)
Tue, Sep 8, 7:17 PM
Unknown Object (File)
Tue, Sep 8, 6:22 PM
View All Files
Subscribers
imp

Details

Reviewers
imp
jrm
jlduran
ashish
Summary

Prefer $(...) over backticks, drop the space before ";" in
conditionals, and normalize sentence-ending punctuation and line
wrapping in comments.

Use printf %s for metalog entries built from path variables so
backslash sequences in paths are printed verbatim.

Collapse the remaining split for loops onto one line to match the
style already used elsewhere in defaults.sh.

Replace sort | uniq with sort -u in setup_nanobsd() and cust_pkgng().

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75882
Build 72765: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Tue, Aug 18, 10:37 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Aug 18, 10:37 PM
senguptaangshuman17_gmail.com requested review of this revision.Tue, Aug 18, 10:37 PM
Harbormaster completed remote builds in B75688: Diff 184284.Tue, Aug 18, 10:37 PM
senguptaangshuman17_gmail.com added a child revision: D58932: nanobsd: Add comments to defaults.sh, legacy.sh.Tue, Aug 18, 10:38 PM
imp added inline comments.Wed, Aug 19, 5:06 AM
tools/tools/nanobsd/defaults.sh
56

I'm no tat all sure that I like this style. Some sentences have a full stop (period) at the end while others do not. It seems needlessly churny for no good benefit.

188

Preferring $() is a great change.

273

But two spaces after a period is something I can get behind.

289

This always should have been printf.

322

I like moving the 'do' up too.

736

shouldn't we indent the cpio more than the find?

senguptaangshuman17_gmail.com added reviewers: imp, jrm, jlduran, ashish.Wed, Aug 19, 5:15 AM
senguptaangshuman17_gmail.com added subscribers: jlduran, ashish, jrm.
senguptaangshuman17_gmail.com removed subscribers: jrm, ashish, jlduran.
jlduran mentioned this in D58964: nanobsd: Add gpt support.Wed, Aug 19, 4:39 PM
jlduran mentioned this in D58957: nanobsd: Remove chflags call in install_world().Wed, Aug 19, 5:34 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184446.Thu, Aug 20, 10:09 AM
Harbormaster completed remote builds in B75780: Diff 184446.Thu, Aug 20, 10:09 AM
senguptaangshuman17_gmail.com marked 6 inline comments as done.Thu, Aug 20, 10:12 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184558.Thu, Aug 20, 3:10 PM

Include style cleanups for FlashDevice.sub

Harbormaster completed remote builds in B75881: Diff 184558.Thu, Aug 20, 3:10 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184559.Thu, Aug 20, 3:10 PM

Include style cleanups for FlashDevice.sub

Harbormaster completed remote builds in B75882: Diff 184559.Thu, Aug 20, 3:10 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184592.Thu, Aug 20, 6:53 PM

Address review comments: style normalization, FlashDevice.sub fixes, and comment cleanups

Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 6:53 PM
Harbormaster completed remote builds in B75906: Diff 184592.Thu, Aug 20, 6:53 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:15 PM
jlduran mentioned this in D58977: nanobsd: Remove spurious MBR-specific stuff.Sun, Aug 23, 2:31 PM
senguptaangshuman17_gmail.com added a comment.EditedSun, Aug 23, 6:52 PM

The full stack of commits can be found here coderangshu/freebsd-src

senguptaangshuman17_gmail.com updated this revision to Diff 184807.Sun, Aug 23, 8:21 PM
Harbormaster completed remote builds in B75994: Diff 184807.Sun, Aug 23, 8:21 PM
senguptaangshuman17_gmail.com mentioned this in D59036: nanobsd: Add _xxx_libarchive_mtree_bug.Sun, Aug 23, 11:05 PM
senguptaangshuman17_gmail.com mentioned this in D58932: nanobsd: Add comments to defaults.sh, legacy.sh.
senguptaangshuman17_gmail.com mentioned this in D59035: nanobsd: Add _xxx_remove_extra_dist_files.
senguptaangshuman17_gmail.com mentioned this in D58934: nanobsd: Add _xxx_includes.subr.
senguptaangshuman17_gmail.com mentioned this in D58963: nanobsd: Disable dumpdev.
senguptaangshuman17_gmail.com mentioned this in D58933: nanobsd: Add an err() convenience function.
jlduran added a comment.Mon, Aug 24, 2:47 PM
In D58931#1356122, @senguptaangshuman17_gmail.com wrote:

The full stack of commits can be found here coderangshu/freebsd-src

Thank you! It is easier for me to track these changes directly from git.
I would remind consumers of this branch, that it gets interactively rebased on top of the main branch on a weekly basis.

senguptaangshuman17_gmail.com updated this revision to Diff 184986.Tue, Aug 25, 6:13 AM
Harbormaster completed remote builds in B76109: Diff 184986.Tue, Aug 25, 6:13 AM
jlduran mentioned this in D58956: nanobsd: Use local repository cache for precompiled package base builds.Wed, Aug 26, 2:49 PM
senguptaangshuman17_gmail.com updated this revision to Diff 185241.Thu, Aug 27, 9:32 PM

Style and comment formatting fixups in defaults.sh

Harbormaster completed remote builds in B76231: Diff 185241.Thu, Aug 27, 9:32 PM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
13 lines
88 lines
23 lines
32 lines

Diff 184559

View Options

tools/tools/nanobsd/FlashDevice.sub

Loading...
View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/legacy.sh

Loading...
View Options

tools/tools/nanobsd/nanobsd.sh

Loading...