Differential D58972

nanobsd: Use NANO_NAME
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 24, 7:21 PM

	Unknown Object (File)
	Mon, Aug 24, 4:52 PM

	Unknown Object (File)
	Mon, Aug 24, 1:51 PM

	Unknown Object (File)
	Mon, Aug 24, 8:43 AM

	Unknown Object (File)
	Mon, Aug 24, 5:32 AM

	Unknown Object (File)
	Mon, Aug 24, 4:12 AM

	Unknown Object (File)
	Sun, Aug 23, 10:50 PM

	Unknown Object (File)
	Sun, Aug 23, 8:37 PM

View All 20 Files

Subscribers

Details

Reviewers

jlduran
jrm
ashish

Summary

Interpolate NANO_NAME into NANO_IMGNAME instead of hard coding the
full tag into the image name.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76134
Build 73017: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:25 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:25 AM

senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:25 AM

Harbormaster completed remote builds in B75725: Diff 184338.Wed, Aug 19, 10:25 AM

senguptaangshuman17_gmail.com added a parent revision: D58971: nanobsd: Custom function to adapt adduser(8).Wed, Aug 19, 10:26 AM

senguptaangshuman17_gmail.com added a child revision: D58973: nanobsd: Add ports-kmods package as well.

senguptaangshuman17_gmail.com updated this revision to Diff 184472.Thu, Aug 20, 10:12 AM

Harbormaster completed remote builds in B75806: Diff 184472.Thu, Aug 20, 10:12 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184523.Thu, Aug 20, 12:24 PM

Harbormaster completed remote builds in B75852: Diff 184523.Thu, Aug 20, 12:24 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184568.Thu, Aug 20, 3:12 PM

Harbormaster completed remote builds in B75891: Diff 184568.Thu, Aug 20, 3:12 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184846.Sun, Aug 23, 11:04 PM

Harbormaster completed remote builds in B76032: Diff 184846.Sun, Aug 23, 11:04 PM

imp added inline comments.Sun, Aug 23, 11:07 PM

tools/tools/nanobsd/defaults.sh
63	This will force several changes in our internal tooling...

senguptaangshuman17_gmail.com added inline comments.Mon, Aug 24, 6:50 PM

tools/tools/nanobsd/defaults.sh
63	This will force several changes in our internal tooling... Default NANO_NAME is still full, so NANO_IMGNAME still resolves to _.disk.full by default. Only configs that override NANO_NAME to a non-default value would see the image name and NANO_OBJ dir change, and for those the old hardcoded _.disk.full was arguably already wrong (image name not reflecting the actual variant built).

senguptaangshuman17_gmail.com updated this revision to Diff 184952.Tue, Aug 25, 6:09 AM

Harbormaster completed remote builds in B76075: Diff 184952.Tue, Aug 25, 6:09 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76134: Diff 185011.Tue, Aug 25, 8:01 AM

Revision Contents
Changeset List

Path

Size

tools/

tools/

nanobsd/

2 lines

Diff 185011

tools/tools/nanobsd/defaults.sh

Loading...