libifconfig: Add a native SR-IOV VF status query
Needs ReviewPublic
Actions

Authored by kbowling on Mon, Aug 10, 11:00 PM.

Tags

None

Referenced Files

	F167426216: D58777.id184033.diff
	Fri, Aug 21, 4:12 PM

	F167407604: D58777.id183845.diff
	Fri, Aug 21, 2:35 PM

	F167401531: D58777.id183845.diff
	Fri, Aug 21, 1:46 PM

	F167372256: D58777.diff
	Fri, Aug 21, 10:56 AM

	F167365801: D58777.id184030.diff
	Fri, Aug 21, 9:08 AM

	F167355791: D58777.id184033.diff
	Fri, Aug 21, 6:11 AM

	Unknown Object (File)
	Thu, Aug 20, 8:06 PM

	Unknown Object (File)
	Thu, Aug 20, 4:32 PM

View All 29 Files

Subscribers

imp

melifaro

Details

Reviewers

pouria
glebius

Summary

Request RTEXT_FILTER_VF through route Netlink and parse the common VF
status schema into typed public structures.  Preserve per-field
presence using IFLAF_VF_* attribute numbers as mask bit indices so
callers can distinguish omitted values from false or zero.

Validate required VF indices, repeated driver namespaces, and their
versioned typed fields while allowing unknown optional attributes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Mon, Aug 10, 11:00 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Aug 10, 11:00 PM

kbowling requested review of this revision.Mon, Aug 10, 11:00 PM

kbowling added a parent revision: D58776: rtnetlink: Add native SR-IOV VF status.

kbowling added a child revision: D58778: ifconfig: Add SR-IOV VF status output.Mon, Aug 10, 11:02 PM

melifaro added a subscriber: melifaro.Thu, Aug 13, 11:57 PM

melifaro added inline comments.

lib/libifconfig/libifconfig.h
217	Those should come from the kernel headers
249	if we really want to have this snl passthru we should use definitions from the snl header
276	Why can't `if_vf_info` from snl be used here?