Page MenuHomeFreeBSD

libifconfig: Add a native SR-IOV VF status query
Needs ReviewPublic

Authored by kbowling on Mon, Aug 10, 11:00 PM.
Tags
None
Referenced Files
F167150425: D58777.diff
Wed, Aug 19, 12:33 PM
F167128852: D58777.id.diff
Wed, Aug 19, 8:27 AM
F167102927: D58777.id183845.diff
Wed, Aug 19, 2:54 AM
F167070280: D58777.id184033.diff
Tue, Aug 18, 8:37 PM
F167066347: D58777.id184030.diff
Tue, Aug 18, 8:32 PM
F167063606: D58777.diff
Tue, Aug 18, 8:26 PM
Unknown Object (File)
Tue, Aug 18, 3:26 AM
Unknown Object (File)
Mon, Aug 17, 11:57 AM
Subscribers

Details

Reviewers
pouria
glebius
Summary
Request RTEXT_FILTER_VF through route Netlink and parse the common VF
status schema into typed public structures.  Preserve per-field
presence using IFLAF_VF_* attribute numbers as mask bit indices so
callers can distinguish omitted values from false or zero.

Validate required VF indices, repeated driver namespaces, and their
versioned typed fields while allowing unknown optional attributes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

melifaro added inline comments.
lib/libifconfig/libifconfig.h
217

Those should come from the kernel headers

249

if we really want to have this snl passthru we should use definitions from the snl header

276

Why can't if_vf_info from snl be used here?

kbowling edited the summary of this revision. (Show Details)

Maps every IFLAF_VF_* presence bit to the stable public IFCONFIG_VF_F_* flags

Use netlink/route/interface.h