Details

Reviewers

kevans
markj

Commits

rG3f88f6b89942: kqueue.2: document EVFILT_PROCDESC support for NOTE_FORK
rGe8d4d754e1c7: EVFILT_PROCDESC: support NOTE_FORK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Jul 17 2026, 5:41 AM

Herald added subscribers: ziaee, olce, imp. · View Herald TranscriptJul 17 2026, 5:41 AM

kib requested review of this revision.Jul 17 2026, 5:41 AM

markj added inline comments.Jul 17 2026, 1:32 PM

lib/libsys/kqueue.2
597
601
602	Also, if the process raises NOTE_EXIT, the last PID will be overwritten (but I think we will return NOTE_FORK \| NOTE_EXIT).
605	Perhaps mention ptrace(2) explicitly?
sys/kern/sys_procdesc.c
521	Probably you want to `kn->kn_flags &= ~NOTE_FORK` here?

kib marked 5 inline comments as done.Jul 17 2026, 1:57 PM

kib added inline comments.

sys/kern/sys_procdesc.c
521	Hm, no. I will explicitly mention that exit code is returned.

Update the man page with the review comments.

markj added inline comments.Jul 17 2026, 1:58 PM

sys/kern/sys_procdesc.c
521	(I meant `kn->kn_fflags` above of course.)

kib marked an inline comment as done.Jul 17 2026, 2:11 PM

kib added inline comments.

sys/kern/sys_procdesc.c
521	I do want (need) to see NOTE_FORK in this situation.

Report NOTE_FORK for procdesc after the child is attached to the debugger.

In D58292#1337327, @kib wrote:

Report NOTE_FORK for procdesc after the child is attached to the debugger.

I suggest adding a test for this, or at least a comment explaining why it is important.

lib/libsys/kqueue.2
597	since you use it below. Or write, `The process identifier (PID) of the ...`
605
606

In D58292#1337369, @markj wrote:

In D58292#1337327, @kib wrote:

Report NOTE_FORK for procdesc after the child is attached to the debugger.

I suggest adding a test for this, or at least a comment explaining why it is important.

I added the comment. truss(1) in the cap mode is the practical test.

Add comment for the placement of NOTE_FORK activation.
Edit the man page.

markj accepted this revision.Jul 19 2026, 6:38 PM

markj added inline comments.

lib/libsys/kqueue.2
629
sys/kern/kern_fork.c
830
832
833

This revision is now accepted and ready to land.Jul 19 2026, 6:38 PM

Edit comments and the man page update.

This revision now requires review to proceed.Jul 19 2026, 6:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 19 2026, 8:41 PM

Closed by commit rGe8d4d754e1c7: EVFILT_PROCDESC: support NOTE_FORK (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGe8d4d754e1c7: EVFILT_PROCDESC: support NOTE_FORK.

kib added a commit: rG3f88f6b89942: kqueue.2: document EVFILT_PROCDESC support for NOTE_FORK.

EVFILT_PROCDESC: support NOTE_FORK
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 182152

lib/libsys/kqueue.2

sys/kern/kern_fork.c

sys/kern/sys_procdesc.c

sys/sys/event.h

sys/sys/procdesc.h

EVFILT_PROCDESC: support NOTE_FORKClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 182152

lib/libsys/kqueue.2

sys/kern/kern_fork.c

sys/kern/sys_procdesc.c

sys/sys/event.h

sys/sys/procdesc.h

EVFILT_PROCDESC: support NOTE_FORK
ClosedPublic
Actions

Revision Contents
Changeset List