EVFILT_PROCDESC: support NOTE_FORK

[markj]

lib/libsys/kqueue.2

597 ↗

(On Diff #182106)

601 ↗

(On Diff #182106)

602 ↗

(On Diff #182106)

Also, if the process raises NOTE_EXIT, the last PID will be overwritten (but I think we will return NOTE_FORK | NOTE_EXIT).

605 ↗

(On Diff #182106)

Perhaps mention ptrace(2) explicitly?

sys/kern/sys_procdesc.c

521

Probably you want to kn->kn_flags &= ~NOTE_FORK here?

[kib]

sys/kern/sys_procdesc.c

521

Hm, no. I will explicitly mention that exit code is returned.

[kib]

Update the man page with the review comments.

[markj]

sys/kern/sys_procdesc.c

521

(I meant kn->kn_fflags above of course.)

[kib]

sys/kern/sys_procdesc.c

521

I do want (need) to see NOTE_FORK in this situation.

[kib]

Report NOTE_FORK for procdesc after the child is attached to the debugger.

[markj]

In D58292#1337327, @kib wrote:

Report NOTE_FORK for procdesc after the child is attached to the debugger.

I suggest adding a test for this, or at least a comment explaining why it is important.

lib/libsys/kqueue.2

597 ↗

(On Diff #182152)

since you use it below. Or write, The process identifier (PID) of the ...

605 ↗

(On Diff #182152)

606 ↗

(On Diff #182152)

[kib]

In D58292#1337369, @markj wrote:

In D58292#1337327, @kib wrote:

Report NOTE_FORK for procdesc after the child is attached to the debugger.

I suggest adding a test for this, or at least a comment explaining why it is important.

I added the comment. truss(1) in the cap mode is the practical test.

[kib]

Add comment for the placement of NOTE_FORK activation.
Edit the man page.

[markj]

lib/libsys/kqueue.2

629 ↗

(On Diff #182159)

sys/kern/kern_fork.c

830

832

833

[kib]

Edit comments and the man page update.