flua: Always build as a bootstrap tool
ClosedPublic
Actions

Authored by ivy on Mon, Apr 6, 1:45 PM.

Details

Reviewers

kevans
emaste
imp

Group Reviewers

pkgbase

Commits

rGa42f229f4c1e: flua: Always build as a bootstrap tool
rG50de0bf50512: flua: Always build as a bootstrap tool

Summary

We want to use flua from the source tree (not the host) during package
build, firstly to protect us from breaking changes in lua or libucl,
and secondly to allow (in future) cross-building of packages from
Linux or macOS.

Since we don't know if the user will be building packages during the
bootstrap phase, and because flua is fairly small and generally useful,
build it as a bootstrap tool unconditionally.

MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71986
Build 68869: arc lint + arc unit

Event Timeline

ivy requested review of this revision.Mon, Apr 6, 1:45 PM

ivy created this revision.

Harbormaster completed remote builds in B71986: Diff 174963.Mon, Apr 6, 1:45 PM

I'd /maybe/ consider leaving libmd behind a BOOTSTRAPPING == 0 since it's entirely a FreeBSD project, but I don't feel strongly about it -- libmd doesn't take that long to build.

This revision is now accepted and ready to land.Mon, Apr 6, 1:49 PM

In D56270#1287480, @kevans wrote:

I'd /maybe/ consider leaving libmd behind a BOOTSTRAPPING == 0 since it's entirely a FreeBSD project, but I don't feel strongly about it -- libmd doesn't take that long to build.

Oh wait, the flua bootstrap build probably can't be split like that today- sorry.

ivy added a child revision: D56271: packages: Always use the bootstrap flua.Mon, Apr 6, 1:57 PM

emaste accepted this revision.Mon, Apr 6, 2:05 PM

Closed by commit rG50de0bf50512: flua: Always build as a bootstrap tool (authored by ivy). · Explain WhyTue, Apr 7, 11:04 AM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG50de0bf50512: flua: Always build as a bootstrap tool.

ivy added a commit: rGa42f229f4c1e: flua: Always build as a bootstrap tool.Sun, Apr 12, 11:15 PM