Page MenuHomeFreeBSD
Differential D55947

arm64: mte: handle synchronous tag check faults
ClosedPublic
Actions

Authored by andrew on Thu, Mar 19, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 16, 1:22 AM
Unknown Object (File)
Tue, Apr 14, 4:58 AM
Unknown Object (File)
Sun, Apr 12, 7:32 PM
Unknown Object (File)
Sun, Apr 12, 6:07 AM
Unknown Object (File)
Sat, Apr 11, 8:03 PM
Unknown Object (File)
Sat, Apr 11, 4:01 PM
Unknown Object (File)
Sat, Apr 11, 6:06 AM
Unknown Object (File)
Wed, Apr 8, 9:56 AM
View All 14 Files
Subscribers
emaste
imp
kib

Details

Reviewers
manu
kib
Group Reviewers
arm64
Commits
rG6f9e9eba984f: arm64: mte: handle synchronous tag check faults
Summary

The Memory Tagging Extension supports both Synchronous and Asynchronous
faults, called Tag Check Faults, which are configurable via
SCTLR_EL1.TCF0 for userspace and SCTLR_EL1.TCF for the kernel.

This commit adds support for handling synchronous tag check faults at
EL0 and EL1, although these are only enabled on a per-process basis in
userspace, kernel space does not enable tag check faults. A TCF in the
kernel will cause a kernel panic like any other virtual memory fault,
and a TCF in userspace will result in a SIGSEGV

Sponsored by: Arm Ltd
Signed-off-by: Harry Moulton <harry.moulton@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71528
Build 68411: arc lint + arc unit

Event Timeline

andrew created this revision.Thu, Mar 19, 4:05 PM
Herald added a reviewer: manu. · View Herald TranscriptThu, Mar 19, 4:05 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B71528: Diff 173917.Thu, Mar 19, 4:05 PM
andrew requested review of this revision.Thu, Mar 19, 4:05 PM
andrew added a parent revision: D55946: arm64: mte: configure initial state for system registers.
andrew added a child revision: D55948: arm64: mte: add tagged memory attribute.
andrew added inline comments.Thu, Mar 19, 4:26 PM
sys/sys/signal.h
309–310

These should probably be 100 & 101 or similar

andrew added a subscriber: kib.Mon, Apr 13, 2:28 PM
andrew added inline comments.
sys/sys/signal.h
309–310

@kib Do you have a preference for what values these should be? They will be architecture dependant like SEGV_PKUERR below.

kib added inline comments.Mon, Apr 13, 8:07 PM
sys/sys/signal.h
309–310

Yes, I selected some high value for amd PKRU to allow space for MI code additions. So 100 and later are fine as arch-specific values.

Please add a prefix into the comment, like /* arm64: synchronous MTE ... */

andrew updated this revision to Diff 175483.Tue, Apr 14, 9:32 AM

Change the SEGV_MTE* values

Harbormaster completed remote builds in B72191: Diff 175483.Tue, Apr 14, 9:32 AM
kib accepted this revision.Tue, Apr 14, 9:56 AM
This revision is now accepted and ready to land.Tue, Apr 14, 9:56 AM
Closed by commit rG6f9e9eba984f: arm64: mte: handle synchronous tag check faults (authored by harry.moulton_arm.com, committed by andrew). · Explain WhyThu, Apr 16, 2:23 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG6f9e9eba984f: arm64: mte: handle synchronous tag check faults.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
22 lines
sys/
2 lines

Diff 173917

View Options

sys/arm64/arm64/trap.c

Loading...
View Options

sys/sys/signal.h

Loading...