Page MenuHomeFreeBSD
Differential D55927

tests: Add grand link-layer event
ClosedPublic
Actions

Authored by pouria on Wed, Mar 18, 10:51 PM.
Tags
None
Referenced Files
F150443081: D55927.id173871.diff
Wed, Apr 1, 6:18 AM
Unknown Object (File)
Thu, Mar 26, 9:16 AM
Unknown Object (File)
Thu, Mar 26, 6:56 AM
Unknown Object (File)
Thu, Mar 26, 3:20 AM
Unknown Object (File)
Thu, Mar 26, 12:02 AM
Unknown Object (File)
Wed, Mar 25, 10:26 PM
Unknown Object (File)
Wed, Mar 25, 4:08 AM
Unknown Object (File)
Mon, Mar 23, 6:02 PM
View All 14 Files
Subscribers
ae
asomers
bms
imp
melifaro

Details

Reviewers
glebius
zlei
adrian
bz
Group Reviewers
network
Commits
rG2371b24c22f0: tests: Add grand link-layer event in netinet6/ndp
Summary

Add test for ndp to verity link-layer
address change event actually triggers the grand.

Test Plan

Run the test below:

kyua debug -k /usr/tests/Kyuafile sys/netinet6/ndp:ndp_grand_linklayer_event

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71497
Build 68380: arc lint + arc unit

Event Timeline

pouria created this revision.Wed, Mar 18, 10:51 PM
Herald added subscribers: melifaro, ae, asomers, imp. · View Herald TranscriptWed, Mar 18, 10:51 PM
pouria requested review of this revision.Wed, Mar 18, 10:51 PM
Harbormaster completed remote builds in B71496: Diff 173871.Wed, Mar 18, 10:51 PM
glebius added inline comments.Wed, Mar 18, 10:58 PM
tests/sys/netinet6/ndp.sh
406

What is the actual timer in the kernel? If it is 1 second, I'd suggest to sleep 1.1.

406

You may also want to check ndp output immediately after ifconfig, before sleep.

pouria updated this revision to Diff 173872.Wed, Mar 18, 11:08 PM

Address @glebius comment.

Harbormaster completed remote builds in B71497: Diff 173872.Wed, Mar 18, 11:08 PM
pouria updated this revision to Diff 173873.Wed, Mar 18, 11:14 PM

style(9)

Harbormaster completed remote builds in B71498: Diff 173873.Wed, Mar 18, 11:14 PM
pouria mentioned this in D55905: ndp: Accept multiple queued ND for non-GRAND NAs.Wed, Mar 18, 11:18 PM
pouria added a reviewer: bz.Thu, Mar 26, 11:40 AM
pouria added a comment.EditedFri, Mar 27, 11:08 AM

I'm planning to commit this tonight around 9:30 PM +3:30 (of course, if I don't get disconnected).
I would appreciate any input on this review.

pouria updated this revision to Diff 174377.Fri, Mar 27, 11:31 AM

Change mac address to *unicast UAA* and reuse mac address of previous tests for consistency.

Harbormaster completed remote builds in B71739: Diff 174377.Fri, Mar 27, 11:31 AM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Mar 27, 8:51 PM
Closed by commit rG2371b24c22f0: tests: Add grand link-layer event in netinet6/ndp (authored by pouria). · Explain Why
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG2371b24c22f0: tests: Add grand link-layer event in netinet6/ndp.

Revision Contents
Changeset List

PathSize
tests/
sys/
netinet6/
49 lines

Diff 173872

View Options

tests/sys/netinet6/ndp.sh

Loading...