Differential D55509
bsd.port.mk: also export GNU strip when USE_BINUTILS is set Authored by royger on Wed, Feb 25, 2:19 PM. Tags None Referenced Files
Subscribers None
Details GNU Binutils packages strip, and should be used in preference to the base Do not take over the STRIP makefile variable, which is already used in bsd.port.mk to signal whether the install program should strip the binaries. Instead define STRIP_CMD and use STRIP just for the environment variables.
Diff Detail
Event TimelineComment Actions Picked the last couple of people that modified that file, and you happened to be there :). Thanks, will wait a bit for someone from ports to voice an opinion. Comment Actions Can I please get an Ack/Nack from portmgr? This is required for SeaBIOS to be functional again when built on FreeBSD >= 15. Comment Actions Well, like everything committer related, it's in the committer's guide https://docs.freebsd.org/en/articles/committers-guide/#ports-exp-run, but I don't see what would break with this change. There are not too many ports with USE_BINUTILS though, you could test build them :-) Comment Actions Right, however my FreeBSD development box died yesterday, and I won't get the replacement parts until Monday to bring it back up. I don't mind waiting, but I also would be very surprised for this to break anything. Ports using USE_BINUTILS must work fine with GNU strip I would think :). Comment Actions Do not take over the STRIP makefile variable, which is already used in bsd.port.mk to signal whether the install program should strip the binaries. Instead define STRIP_CMD and use STRIP just for the environment variables. Comment Actions I've tested with this fix and I'm able to build all the USE_BINUTILS ports, except for GCC which I haven't tried because my box runs out of memory when building it. Comment Actions Ping? I would like to get this done sooner rather than later so the SeaBIOS port is functional again. Without this change the generated SeaBIOS firmware image is non-functional. |