witness: report a thread that can't sleep in WITNESS_WARN
ClosedPublic
Actions

Authored by glebius on Mon, Feb 16, 10:55 PM.

Details

Reviewers

kib
markj

Commits

rG6feb16b77e7d: witness: report a thread that can't sleep in WITNESS_WARN

Summary

Although this is not related to locking, but seems to be the right
place to catch violators, given that WITNESS_WARN is already used
widely in the kernel.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71206
Build 68089: arc lint + arc unit

Event Timeline

glebius created this revision.Mon, Feb 16, 10:55 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Feb 16, 10:55 PM

glebius requested review of this revision.Mon, Feb 16, 10:55 PM

Harbormaster completed remote builds in B70717: Diff 172034.Mon, Feb 16, 10:55 PM

Immediately caught in bridge(4):

NET_EPOCH_ENTER(et);

callout_drain(&sc->sc_brcallout);

glebius added a subscriber: pouria.Mon, Feb 16, 10:56 PM

kib accepted this revision.Tue, Feb 17, 2:53 AM

kib added inline comments.

sys/kern/subr_witness.c
2140	IMO it is cleaner to inline THREAD_CAN_SLEEP() because the whole function operates on td. The right hand of && is not style-compliant.

This revision is now accepted and ready to land.Tue, Feb 17, 2:53 AM

markj accepted this revision.Tue, Feb 17, 2:43 PM

markj added inline comments.

sys/kern/subr_witness.c
2144

In D55316#1265083, @glebius wrote:
Immediately caught in bridge(4):
NET_EPOCH_ENTER(et);

callout_drain(&sc->sc_brcallout);

Are we waiting for this?
Do you want me to work on bridge?

Apply Kostik's & Mark's suggestions

This revision now requires review to proceed.Thu, Mar 5, 6:42 PM

Harbormaster completed remote builds in B71206: Diff 173211.Thu, Mar 5, 6:42 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Mar 5, 6:44 PM

Closed by commit rG6feb16b77e7d: witness: report a thread that can't sleep in WITNESS_WARN (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG6feb16b77e7d: witness: report a thread that can't sleep in WITNESS_WARN.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_witness.c

9 lines

Diff 173211

View Options

witness: report a thread that can't sleep in WITNESS_WARNClosedPublicActions