Page MenuHomeFreeBSD

bsd.port.mk: also export GNU strip when USE_BINUTILS is set
Needs ReviewPublic

Authored by royger on Wed, Feb 25, 2:19 PM.
Tags
None
Referenced Files
F147777844: D55509.diff
Fri, Mar 13, 2:22 PM
Unknown Object (File)
Wed, Mar 11, 8:02 AM
Unknown Object (File)
Wed, Mar 11, 7:20 AM
Unknown Object (File)
Wed, Mar 11, 3:45 AM
Unknown Object (File)
Tue, Mar 10, 11:36 AM
Unknown Object (File)
Mon, Mar 9, 10:35 AM
Unknown Object (File)
Fri, Mar 6, 12:06 AM
Unknown Object (File)
Tue, Mar 3, 3:22 AM
Subscribers
None

Details

Reviewers
bapt
dim
mat
delphij
arrowd
cy
Group Reviewers
portmgr
Summary

GNU Binutils packages strip, and should be used in preference to the base
LLVM strip when USE_BINUTILS = yes.

Do not take over the STRIP makefile variable, which is already used in bsd.port.mk to signal whether the install program should strip the binaries. Instead define STRIP_CMD and use STRIP just for the environment variables.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

royger created this revision.

Sounds reasonable to me, but I'm not a ports committer. :)

This revision is now accepted and ready to land.Wed, Feb 25, 3:25 PM

Picked the last couple of people that modified that file, and you happened to be there :). Thanks, will wait a bit for someone from ports to voice an opinion.

Makes sense to me too, but the last word is portmgr 's.

Can I please get an Ack/Nack from portmgr? This is required for SeaBIOS to be functional again when built on FreeBSD >= 15.

I don't think this should break too many things.

Does it need an exp-run? Because I have no idea how to do that.

Well, like everything committer related, it's in the committer's guide https://docs.freebsd.org/en/articles/committers-guide/#ports-exp-run, but I don't see what would break with this change.

There are not too many ports with USE_BINUTILS though, you could test build them :-)

In D55509#1273416, @mat wrote:

Well, like everything committer related, it's in the committer's guide https://docs.freebsd.org/en/articles/committers-guide/#ports-exp-run, but I don't see what would break with this change.

There are not too many ports with USE_BINUTILS though, you could test build them :-)

Right, however my FreeBSD development box died yesterday, and I won't get the replacement parts until Monday to bring it back up. I don't mind waiting, but I also would be very surprised for this to break anything. Ports using USE_BINUTILS must work fine with GNU strip I would think :).

royger edited the summary of this revision. (Show Details)

Do not take over the STRIP makefile variable, which is already used in bsd.port.mk to signal whether the install program should strip the binaries. Instead define STRIP_CMD and use STRIP just for the environment variables.

This revision now requires review to proceed.Tue, Mar 10, 11:38 AM

I've tested with this fix and I'm able to build all the USE_BINUTILS ports, except for GCC which I haven't tried because my box runs out of memory when building it.