bhyve: make BHYVE_SNAPSHOT amd64-only
ClosedPublic
Actions

Authored by novel on Jan 25 2026, 11:55 AM.

Details

Reviewers

markj
emaste

Group Reviewers

bhyve

Commits

rGbffa54b58cbf: bhyve: make BHYVE_SNAPSHOT amd64-only
rG139f620c0c90: bhyve: make BHYVE_SNAPSHOT amd64-only
rG50b0a2002c15: bhyve: make BHYVE_SNAPSHOT amd64-only
rGb01763b2b2ab: bhyve: make BHYVE_SNAPSHOT amd64-only

Summary

Build fails with BHYVE_SNAPSHOT enabled on non-amd64,
so add it to BROKEN_OPTIONS for these arches.

PR: 292686

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

novel created this revision.Jan 25 2026, 11:55 AM

Herald added a reviewer: bhyve. · View Herald TranscriptJan 25 2026, 11:55 AM

Herald added subscribers: bcran, jonathan, rgrimes, imp. · View Herald Transcript

novel requested review of this revision.Jan 25 2026, 11:55 AM

Harbormaster completed remote builds in B70128: Diff 170374.Jan 25 2026, 11:55 AM

If someone comes along wanting to add snapshot support for other arches, they'll have to revert this patch.

IMO it would be better to just have a check in the bhyve makefile:

.if ${MK_BHYVE_SNAPSHOT} != "no" && ${MACHINE_CPUARCH} != "amd64"
.error bhyve snapshot support is only implemented on amd64.
.endif

afedorov added a subscriber: afedorov.Jan 25 2026, 11:29 PM

In D54873#1254599, @markj wrote:
If someone comes along wanting to add snapshot support for other arches, they'll have to revert this patch.

IMO it would be better to just have a check in the bhyve makefile:
.if ${MK_BHYVE_SNAPSHOT} != "no" && ${MACHINE_CPUARCH} != "amd64"
.error bhyve snapshot support is only implemented on amd64.
.endif

Yeah, I though about that. On the other hand, I see the BHYVE_SNAPSHOT as a temporary knob that will go away eventually (and users are requesting that: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289848). Not sure what happens sooner: arch64 gets snapshot support or this knob gets deprecated.