Page MenuHomeFreeBSD
Differential D54765

sleep: fix SIGINFO output and modernize interval parsing
Needs ReviewPublic
Actions

Authored by nvsrahul_hotmail.com on Sun, Jan 18, 12:47 PM.
Tags
None
Referenced Files
F142364492: D54765.id170003.diff
Mon, Jan 19, 3:10 AM
F142361301: D54765.diff
Mon, Jan 19, 2:00 AM
F142361271: D54765.diff
Mon, Jan 19, 2:00 AM
F142361160: D54765.id169995.diff
Mon, Jan 19, 1:57 AM
F142357284: D54765.id.diff
Mon, Jan 19, 12:30 AM
F142356529: D54765.id170001.diff
Mon, Jan 19, 12:14 AM
F142356085: D54765.id169998.largetrue.diff
Mon, Jan 19, 12:05 AM
F142354798: D54765.id169998.largetrue.diff
Sun, Jan 18, 11:37 PM
View All 22 Files
Subscribers
imp

Details

Reviewers
imp
pouria
delphij
Group Reviewers
network
NetApp
Klara
Summary

Replace sscanf-based interval parsing with strtod(3) to match
documented behavior and improve error handling. Fix SIGINFO
handling to print remaining sleep time to stdout as specified
by sleep(1).

Signed-off-by: NVSRahul <nvsrahul@hotmail.com>

Test Plan

Tested interval parsing with integer and fractional values
using s, m, h, and d units. Verified invalid inputs are rejected.
Confirmed SIGINFO output is printed to stdout and works correctly
with stdout redirection.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69971
Build 66854: arc lint + arc unit

Event Timeline

nvsrahul_hotmail.com created this revision.Sun, Jan 18, 12:47 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Jan 18, 12:47 PM
nvsrahul_hotmail.com requested review of this revision.Sun, Jan 18, 12:47 PM
Harbormaster completed remote builds in B69964: Diff 169995.Sun, Jan 18, 12:47 PM
nvsrahul_hotmail.com added a reviewer: imp.Sun, Jan 18, 12:49 PM
nvsrahul_hotmail.com updated this revision to Diff 169998.Sun, Jan 18, 1:11 PM
  • sleep: fix SIGINFO output and modernize interval parsing
Herald added a reviewer: andrew. · View Herald TranscriptSun, Jan 18, 1:11 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: olce. · View Herald Transcript
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: riscv, linuxkpi, ivy and 18 others. · View Herald Transcript
Harbormaster completed remote builds in B69965: Diff 169998.Sun, Jan 18, 1:11 PM
nvsrahul_hotmail.com updated this revision to Diff 170000.Sun, Jan 18, 1:16 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69966: Diff 170000.Sun, Jan 18, 1:16 PM
nvsrahul_hotmail.com updated this revision to Diff 170001.Sun, Jan 18, 1:20 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69967: Diff 170001.Sun, Jan 18, 1:20 PM
nvsrahul_hotmail.com removed subscribers: bdrewery, asomers, jhibbits and 18 others.Sun, Jan 18, 1:21 PM
nvsrahul_hotmail.com removed a reviewer: bhyve.Sun, Jan 18, 1:24 PM
nvsrahul_hotmail.com updated this revision to Diff 170002.Sun, Jan 18, 1:49 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69968: Diff 170002.Sun, Jan 18, 1:49 PM
nvsrahul_hotmail.com updated this revision to Diff 170003.Sun, Jan 18, 2:08 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69969: Diff 170003.Sun, Jan 18, 2:08 PM
nvsrahul_hotmail.com updated this revision to Diff 170004.Sun, Jan 18, 2:10 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69970: Diff 170004.Sun, Jan 18, 2:10 PM
nvsrahul_hotmail.com updated this revision to Diff 170005.Sun, Jan 18, 2:12 PM

Updated D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69971: Diff 170005.Sun, Jan 18, 2:12 PM
nvsrahul_hotmail.com edited reviewers, added: pouria, delphij, network, NetApp, Klara; removed: andrew, manu, olce.Sun, Jan 18, 2:24 PM
imp added inline comments.Sun, Jan 18, 2:27 PM
bin/sleep/sleep.c
92

So if endptr[0] was NUL, what guarantees endptr[1] is also NUL.

nvsrahul_hotmail.com updated this revision to Diff 170006.Sun, Jan 18, 2:37 PM

Updated D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69972: Diff 170006.Sun, Jan 18, 2:37 PM
nvsrahul_hotmail.com added a comment.Sun, Jan 18, 2:37 PM

Good catch, thanks.
When *endptr == '\0', accessing endptr[1] is invalid.
I’ve updated the logic to only check endptr[1] when a unit
character is present, avoiding a read past the string terminator.

Revision Contents
Changeset List

PathSize
bin/
sleep/
62 lines

Diff 170005

View Options

bin/sleep/sleep.c

Loading...