Differential D54765

sleep: fix SIGINFO output and modernize interval parsing
Needs ReviewPublic
Actions

Authored by nvsrahul_hotmail.com on Jan 18 2026, 12:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 27, 2:33 AM

	Unknown Object (File)
	Mon, May 25, 3:58 AM

	Unknown Object (File)
	Fri, May 22, 8:52 AM

	Unknown Object (File)
	Tue, May 19, 7:50 AM

	Unknown Object (File)
	Tue, May 19, 5:53 AM

	Unknown Object (File)
	Tue, May 19, 2:35 AM

	Unknown Object (File)
	Mon, May 18, 2:37 PM

	Unknown Object (File)
	Mon, May 18, 2:37 PM

Subscribers

Details

Reviewers

Summary

Replace sscanf-based interval parsing with strtod(3) to match
documented behavior and improve error handling. Fix SIGINFO
handling to print remaining sleep time to stdout as specified
by sleep(1).

Signed-off-by: NVSRahul <nvsrahul@hotmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69967
Build 66850: arc lint + arc unit

Event Timeline

nvsrahul_hotmail.com created this revision.Jan 18 2026, 12:47 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 18 2026, 12:47 PM

nvsrahul_hotmail.com requested review of this revision.Jan 18 2026, 12:47 PM

Harbormaster completed remote builds in B69964: Diff 169995.Jan 18 2026, 12:47 PM

nvsrahul_hotmail.com added a reviewer: imp.Jan 18 2026, 12:49 PM

sleep: fix SIGINFO output and modernize interval parsing

Herald added a reviewer: andrew. · View Herald TranscriptJan 18 2026, 1:11 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a reviewer: olce. · View Herald Transcript

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: riscv, linuxkpi, ivy and 18 others. · View Herald Transcript

Harbormaster completed remote builds in B69965: Diff 169998.Jan 18 2026, 1:11 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69966: Diff 170000.Jan 18 2026, 1:16 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69967: Diff 170001.Jan 18 2026, 1:20 PM

nvsrahul_hotmail.com removed subscribers: bdrewery, asomers, jhibbits and 18 others.Jan 18 2026, 1:21 PM

nvsrahul_hotmail.com removed a reviewer: bhyve.Jan 18 2026, 1:24 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69968: Diff 170002.Jan 18 2026, 1:49 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69969: Diff 170003.Jan 18 2026, 2:08 PM

Updating D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69970: Diff 170004.Jan 18 2026, 2:10 PM

Updated D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69971: Diff 170005.Jan 18 2026, 2:12 PM

nvsrahul_hotmail.com edited reviewers, added: pouria, delphij, network, NetApp, Klara; removed: andrew, manu, olce.Jan 18 2026, 2:24 PM

imp added inline comments.Jan 18 2026, 2:27 PM

bin/sleep/sleep.c
92	So if endptr[0] was NUL, what guarantees endptr[1] is also NUL.

Updated D54765: sleep: fix SIGINFO output and modernize interval parsing

Harbormaster completed remote builds in B69972: Diff 170006.Jan 18 2026, 2:37 PM

Good catch, thanks.
When *endptr == '\0', accessing endptr[1] is invalid.
I’ve updated the logic to only check endptr[1] when a unit
character is present, avoiding a read past the string terminator.

nvsrahul_hotmail.com removed reviewers: pouria, delphij, network, NetApp, Klara.Feb 9 2026, 8:35 AM

nvsrahul_hotmail.com edited the test plan for this revision. (Show Details)Apr 7 2026, 5:29 AM

Revision Contents
Changeset List

Path

Size

bin/

sleep/

64 lines

Diff 170001

bin/sleep/sleep.c

Loading...