Page MenuHomeFreeBSD
Differential D54652

bhyvectl: Generalize bhyve IPC code
ClosedPublic
Actions

Authored by bnovkov on Jan 11 2026, 1:33 PM.
Tags
None
Referenced Files
F171178235: D54652.id.diff
Wed, Sep 9, 7:02 AM
F171104771: D54652.id184777.diff
Tue, Sep 8, 5:40 PM
F171092544: D54652.diff
Tue, Sep 8, 4:02 PM
F171065116: D54652.id169472.diff
Tue, Sep 8, 12:11 PM
Unknown Object (File)
Sun, Sep 6, 5:51 PM
Unknown Object (File)
Sun, Sep 6, 3:29 PM
Unknown Object (File)
Sun, Sep 6, 8:33 AM
Unknown Object (File)
Sun, Sep 6, 12:46 AM
View All Files
Subscribers
bcran
imp
rew
rgrimes

Details

Reviewers
None
Group Reviewers
bhyve
Commits
rGf49f33ef8c53: bhyvectl: Generalize bhyve IPC code
Summary

Move the nvlist-based bhyve IPC code into a separate function.
No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69801
Build 66684: arc lint + arc unit

Event Timeline

bnovkov created this revision.Jan 11 2026, 1:33 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJan 11 2026, 1:33 PM
bnovkov requested review of this revision.Jan 11 2026, 1:33 PM
Harbormaster completed remote builds in B69801: Diff 169472.Jan 11 2026, 1:33 PM
bnovkov added a parent revision: D54651: bhyve/pci_emul.c: Add PCI hotplugging IPC commands.Jan 11 2026, 1:33 PM
bnovkov added a child revision: D54653: bhyvectl: Add device hotplugging options.
rew added a subscriber: rew.Jan 12 2026, 7:44 AM

if possible, it might be worth splitting the ipc changes outside of hot pluggable stack

think you can land the ipc changes without the hot plugging bits

usr.sbin/bhyvectl/bhyvectl.c
253

if you rename nvl to request and then see my suggestion for lines 278-285

278–285

could use nvlist_xfer() instead of nvlist_send() and nvlist_recv()

declare a nvlist_t *reply and then something like reply = nvlist_xfer(socket_fd, request, 0)

bnovkov updated this revision to Diff 169536.Jan 12 2026, 6:57 PM
bnovkov marked 2 inline comments as done.

Address @rew 's comments.

usr.sbin/bhyvectl/bhyvectl.c
278–285

Thank you for the suggestion, nvlist_xfer makes things much simpler.

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Aug 23, 12:03 PM
Closed by commit rGf49f33ef8c53: bhyvectl: Generalize bhyve IPC code (authored by bnovkov). · Explain Why
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rGf49f33ef8c53: bhyvectl: Generalize bhyve IPC code.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyvectl/
24 lines

Diff 169472

View Options

usr.sbin/bhyvectl/bhyvectl.c

Loading...